Fix an issue in the Avx2 code of sparse matrix multiply #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There is an issue with respect to accessing memory outside bounds which is fixed with this change. Reviewed By: dskhudia Differential Revision: D30146214 fbshipit-source-id: 8599603372e9f5fc3f6b7cbc1ef768526e9d2f97
|
This pull request was exported from Phabricator. Differential Revision: D30146214 |
|
This pull request has been merged in a35fa9f. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
…da (pytorch#664) Summary: Pull Request resolved: facebookresearch/FBGEMM#664 X-link: pytorch#3578 `lengths` is a tensor with symbolic shapes. Calling `len` on it will force specialization on it which will cause data dependent failure as shown below: {F1974383976} tlparse: https://fburl.com/74rjmr8e The fix is to replace `len` with equivalent operations which support symbolic shapes. Reviewed By: TroyGarden Differential Revision: D67491452 fbshipit-source-id: ed2207b310697d774a284f296c8d34ca2da61adc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is an issue with respect to accessing memory outside bounds which is fixed with this change.
Reviewed By: dskhudia
Differential Revision: D30146214