HBC to return same tensor shape as logit input. #807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D33026199 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D33026199 |
jasonjk-park
added a commit
to jasonjk-park/FBGEMM
that referenced
this pull request
Dec 13, 2021
Summary: Pull Request resolved: pytorch#807 Instead of returning 1D tensor, return the same shape as input to match with existing implementation. clang-format to format entire file, which touches unrelated portions as well. Reviewed By: jianyuh Differential Revision: D33026199 fbshipit-source-id: 2150b50c0d1104895703cc82ba3cbb3271e46176
jasonjk-park
force-pushed
the
export-D33026199
branch
from
42a999f to
45577f2
Compare
Summary: Pull Request resolved: pytorch#807 Instead of returning 1D tensor, return the same shape as input to match with existing implementation. clang-format to format entire file, which touches unrelated portions as well. Reviewed By: jianyuh Differential Revision: D33026199 fbshipit-source-id: 9ec6d6ffb34598d5b5db8cd12201bd5716120b09
|
This pull request was exported from Phabricator. Differential Revision: D33026199 |
jasonjk-park
force-pushed
the
export-D33026199
branch
from
45577f2 to
b979cc5
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#807 X-link: pytorch#3724 Adds shape information to enable custom ops in torch.compile. Reviewed By: jianyuh Differential Revision: D69993984 fbshipit-source-id: 577c35001e5ad7460500ab96c34dd0947c2df786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of returning 1D tensor, return the same shape as input to match with existing implementation.
clang-format to format entire file, which touches unrelated portions as well.
Differential Revision: D33026199