Skip to content

feat: Add converter for aten::sign unary op #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narendasan merged 2 commits into from
Oct 5, 2022
Merged

feat: Add converter for aten::sign unary op #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94b449
feat: Add converter for sign unary operator
gs-olive Oct 5, 2022
0342c64
Remove round unary from PR
gs-olive Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/conversion/converters/impl/unary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ convert(sqrt, kSQRT);
convert(exp, kEXP);
convert(neg, kNEG);
convert(erf, kERF);
convert(sign, kSIGN);
convert(asinh, kASINH);
convert(acosh, kACOSH);
convert(atanh, kATANH);
Expand Down
34 changes: 34 additions & 0 deletions tests/core/conversion/converters/test_unary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,40 @@ TEST(Converters, ATenReciprocalIntConvertsCorrectly) {
ASSERT_TRUE(torch_tensorrt::tests::util::exactlyEqual(jit_results[0], trt_results[0]));
}

TEST(Converters, ATenSignConvertsCorrectly) {
const auto graph = gen_test_graph("sign");
auto g = std::make_shared<torch::jit::Graph>();
torch::jit::parseIR(graph, g.get());

// Resize range to [-10, 10] to span negative values
auto in = -20 * at::rand({2, 3, 5, 5}, {at::kCUDA}) + 10;
auto params = torch_tensorrt::core::ir::get_static_params(g->inputs(), {});
auto jit_results = torch_tensorrt::tests::util::RunGraph(g, params, {in});

params = torch_tensorrt::core::ir::get_static_params(g->inputs(), {});
auto trt_results = torch_tensorrt::tests::util::RunGraphEngine(g, params, {in});

ASSERT_TRUE(
torch_tensorrt::tests::util::almostEqual(jit_results[0], trt_results[0].reshape_as(jit_results[0]), 2e-6));
}

TEST(Converters, ATenSignConvertsZerosCorrectly) {
const auto graph = gen_test_graph("sign");
auto g = std::make_shared<torch::jit::Graph>();
torch::jit::parseIR(graph, g.get());

// Resize range to [-1, 1] to span negative values, cast to int to include zero
auto in = (-2 * at::rand({7, 3, 1, 5}, {at::kCUDA}) + 1).to(torch::kInt32);
auto params = torch_tensorrt::core::ir::get_static_params(g->inputs(), {});
auto jit_results = torch_tensorrt::tests::util::RunGraph(g, params, {in});

params = torch_tensorrt::core::ir::get_static_params(g->inputs(), {});
auto trt_results = torch_tensorrt::tests::util::RunGraphEngine(g, params, {in});

ASSERT_TRUE(
torch_tensorrt::tests::util::almostEqual(jit_results[0], trt_results[0].reshape_as(jit_results[0]), 2e-6));
}

#define test_unary(unary, name) \
TEST(Converters, ATen##name##ConvertsCorrectly) { \
const auto graph = gen_test_graph(#unary); \
Expand Down