Skip to content

Features: update the fx model for output dtype match #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

wu6u3tw
Copy link
Contributor

@wu6u3tw wu6u3tw commented Jun 21, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot requested a review from frank-wei June 21, 2023 00:12
@wu6u3tw wu6u3tw changed the title change fix Draft: update the fx model for output dtype match Jun 21, 2023
@wu6u3tw wu6u3tw closed this Jun 21, 2023
@wu6u3tw wu6u3tw reopened this Jun 21, 2023
@narendasan narendasan requested a review from gs-olive June 21, 2023 20:38
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me pending CI + Linting passing, I think this will reduce errors in FX related to mismatched types particularly for FP16 engines. A rebase onto main is necessary for the CI to pass here, and linting via pre-commit may be needed for the linter check.

Note: See #2004 for the analogous Dynamo updates

@wu6u3tw
Copy link
Contributor Author

wu6u3tw commented Jun 22, 2023

@nvpohanh for viz

@wu6u3tw wu6u3tw changed the title Draft: update the fx model for output dtype match Features: update the fx model for output dtype match Jun 22, 2023
@narendasan
Copy link
Collaborator

Closing as dynamo will handle this

@narendasan narendasan closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants