-
Notifications
You must be signed in to change notification settings - Fork 364
Features: update the fx model for output dtype match #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me pending CI + Linting passing, I think this will reduce errors in FX related to mismatched types particularly for FP16 engines. A rebase onto main
is necessary for the CI to pass here, and linting via pre-commit
may be needed for the linter check.
Note: See #2004 for the analogous Dynamo updates
@nvpohanh for viz |
Closing as dynamo will handle this |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: