feat: support conv dynamo converter #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
gs-olive
reviewed
Aug 23, 2023
Contributor
gs-olive
left a comment
gs-olive
left a comment
There was a problem hiding this comment.
Great to have this converter in Dynamo. Made some suggestions for fixes from issues encountered in the FX path.
gs-olive
reviewed
Aug 24, 2023
Contributor
gs-olive
left a comment
gs-olive
left a comment
There was a problem hiding this comment.
Added a small comment on the changes to the FX directory. After that, just needs a rebase and should be good to go!
zewenli98
force-pushed
the
conv_dynamo_converter
branch
2 times, most recently
from
adc7295 to
17003c4
Compare
Collaborator
Author
|
Thanks! rebased! |
gs-olive
reviewed
Aug 25, 2023
fix a squeeze bug minor fix and issue pytorch#2185 add conv validator
zewenli98
force-pushed
the
conv_dynamo_converter
branch
from
cd734eb to
0644709
Compare
gs-olive
reviewed
Aug 29, 2023
Contributor
gs-olive
left a comment
gs-olive
left a comment
There was a problem hiding this comment.
See below comments on calling convention for converters, then should be good to go!
gs-olive
approved these changes
Aug 29, 2023
Contributor
gs-olive
left a comment
gs-olive
left a comment
There was a problem hiding this comment.
Looks great! Approved, pending CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support conv dynamo converter.
Fixes #2250, #2185
Type of change
Checklist: