Skip to content

fix: Upgrade perf benchmark system #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: Upgrade perf benchmark system #2428

merged 1 commit into from
Nov 1, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Nov 1, 2023

Description

  • Switch model dictionary to lazy-loading scheme
  • Change model references to name-based instead of file-based

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Upgrade perf benchmark system
88bb3bf 
- Switch model dictionary to lazy-loading scheme
- Change model references to name-based instead of file-based
peri044
peri044 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comment for future

tools/perf/hub.py
m["path"] if isinstance(m["path"], (list, tuple)) else [m["path"]]
)
), "Not all 'path' attributes in BENCHMARK_MODELS are valid"

scripted_filename = "models/" + n + "_scripted.jit.pt"
traced_filename = "models/" + n + "_traced.jit.pt"
pytorch_filename = "models/" + n + "_pytorch.pt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove saving pytorch models now ?

@peri044 peri044 merged commit 5763274 into pytorch:perf_refactor Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot