Skip to content

fix: output shape bug in deconv #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zewenli98 merged 2 commits into from
Dec 15, 2023
Merged

fix: output shape bug in deconv #2537

zewenli98 merged 2 commits into from
Dec 15, 2023

Conversation

@zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Dec 13, 2023 •
edited
Loading

Description

Fix an output shape bug in torch.ops.aten.convolution.default (where is_transposed is True).

Fixes #2507

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 13, 2023
@github-actions github-actions bot requested a review from narendasan December 13, 2023 03:17
@zewenli98 zewenli98 requested review from apbose and gs-olive December 13, 2023 03:17
@zewenli98 zewenli98 mentioned this pull request Dec 13, 2023
Closed
@zewenli98 zewenli98 self-assigned this Dec 13, 2023
gs-olive
gs-olive reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - could you add the model (or a minimal sample of it) which originally caused the bug to this file, tests/py/dynamo/backend/test_specialized_models.py?

@github-actions github-actions bot added the component: tests Issues re: Tests label Dec 13, 2023
@zewenli98 zewenli98 requested a review from gs-olive December 13, 2023 04:45
gs-olive
gs-olive approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zewenli98 zewenli98 merged commit 91431a0 into pytorch:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

@apbose apbose Awaiting requested review from apbose

1 more reviewer

@gs-olive gs-olive gs-olive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] RuntimeError: Target aten.convolution.default does not support transposed=True when using torch_tensorrt as backend in torch.compile

3 participants

@zewenli98 @gs-olive @facebook-github-bot