Skip to content

dynamic shape argmax and argmin #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Jul 16, 2024

No description provided.

@apbose apbose requested a review from peri044 July 16, 2024 00:43
@apbose apbose self-assigned this Jul 16, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 16, 2024
@github-actions github-actions bot requested a review from narendasan July 16, 2024 00:43
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

@apbose apbose marked this pull request as draft July 16, 2024 00:49
@apbose apbose force-pushed the dynamic_shape_argmax_argmin branch from 822fdd5 to cb6ef31 Compare July 23, 2024 02:37
@apbose apbose marked this pull request as ready for review July 23, 2024 02:37
@apbose apbose changed the title dynamic shape argmax dynamic shape argmax and argmin Jul 23, 2024
@apbose apbose force-pushed the dynamic_shape_argmax_argmin branch 2 times, most recently from 1b056af to 9cde7a4 Compare July 23, 2024 21:22
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. LGTM

@apbose apbose force-pushed the dynamic_shape_argmax_argmin branch from 9cde7a4 to 3ee1ab5 Compare August 1, 2024 00:25
@peri044
Copy link
Collaborator

peri044 commented Aug 2, 2024

can you rebase so that the CI builds and tests this ?

@apbose apbose force-pushed the dynamic_shape_argmax_argmin branch from 3ee1ab5 to e4d49d8 Compare August 6, 2024 00:12
@apbose apbose force-pushed the dynamic_shape_argmax_argmin branch from e4d49d8 to 1e32992 Compare August 6, 2024 01:43
@peri044 peri044 merged commit baa2eb1 into main Aug 8, 2024
34 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants