Skip to content

ROCM binary upload #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ROCM binary upload #1099

merged 1 commit into from
Oct 17, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Oct 17, 2024

This is a job purely to test ROCM binary upload and not the ROCM test suite. For the test suite we're still waiting on NOVA workflow integration

This seems to just work and you can confirm a dry run push here https://github.com/pytorch/ao/actions/runs/11376979295/job/31650746802?pr=1099 and the for real test will be when this gets kicked off on main as a nightly job

CPU regression test is a flake

Copy link

pytorch-bot bot commented Oct 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1099

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 366a8e3 with merge base c87cc9b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2024
Copy link

pytorch-bot bot commented Oct 17, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@msaroufim msaroufim requested a review from atalman October 17, 2024 02:13
@msaroufim msaroufim mentioned this pull request Oct 17, 2024
17 tasks
@msaroufim msaroufim merged commit 6b52996 into main Oct 17, 2024
29 of 30 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-24 branch October 17, 2024 03:09
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Use Titan's Sequence Parallel strategy

* Fixes for PP to work with Seq P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants