Skip to content

Skip Unit Tests for ROCm CI #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Skip Unit Tests for ROCm CI #1563

merged 2 commits into from
Jan 17, 2025

Conversation

petrex
Copy link
Collaborator

@petrex petrex commented Jan 14, 2025

Skip the unit tests for ROCm CI deployment. refer to #999

This pull request introduces a decorator to skip tests on the ROCm platform and applies this decorator across multiple test files. The most important changes include the addition of the skip_if_rocm decorator and its application to various test functions to handle ROCm-specific issues.

Introduction of skip_if_rocm decorator:

  • test/test_utils.py: Added the skip_if_rocm decorator to skip tests on the ROCm platform with a custom message.

Application of skip_if_rocm decorator:

Copy link

pytorch-bot bot commented Jan 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1563

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 38cab14 with merge base b3deb16 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@petrex petrex requested a review from msaroufim January 14, 2025 20:28
@petrex petrex mentioned this pull request Jan 14, 2025
@petrex petrex self-assigned this Jan 14, 2025
@petrex petrex added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 14, 2025
@petrex petrex force-pushed the skipROCmTest branch 2 times, most recently from 28b5766 to f587e6e Compare January 14, 2025 20:48
@petrex petrex marked this pull request as draft January 14, 2025 21:15
@petrex petrex marked this pull request as ready for review January 15, 2025 00:59
@msaroufim msaroufim requested review from jcaip and removed request for msaroufim January 16, 2025 17:59
@@ -915,6 +921,7 @@ def test_int4_weight_only_quant_subclass(self, device, dtype):
@parameterized.expand(COMMON_DEVICE_DTYPE)
@unittest.skipIf(not TORCH_VERSION_AT_LEAST_2_3, "int4 requires torch nightly.")
# @unittest.skipIf(TORCH_VERSION_AT_LEAST_2_5, "int4 skipping 2.5+ for now")
@skip_if_rocm("ROCm development in progress")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ROCm enablement in progress" would be a better comment.

Copy link

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROCm CI enable-ment in progress. So skipping few UTs temporary, to be debugged and fixed in further PRs.

@amdfaa amdfaa merged commit a1c67b9 into pytorch:main Jan 17, 2025
9 checks passed
@andrewor14
Copy link
Contributor

This caused CI to fail:

  /opt/conda/envs/venv/lib/python3.9/importlib/__init__.py:127: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  test/quantization/test_marlin_qqq.py:6: in <module>
      from test_utils import skip_if_rocm
  E   ModuleNotFoundError: No module named 'test_utils'

I'm reverting this for now

andrewor14 added a commit that referenced this pull request Jan 17, 2025
andrewor14 added a commit that referenced this pull request Jan 17, 2025
Revert "Skip Unit Tests for ROCm CI (#1563)"

This reverts commit a1c67b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants