-
Notifications
You must be signed in to change notification settings - Fork 257
Skip Unit Tests for ROCm CI #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1563
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 38cab14 with merge base b3deb16 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
28b5766
to
f587e6e
Compare
@@ -915,6 +921,7 @@ def test_int4_weight_only_quant_subclass(self, device, dtype): | |||
@parameterized.expand(COMMON_DEVICE_DTYPE) | |||
@unittest.skipIf(not TORCH_VERSION_AT_LEAST_2_3, "int4 requires torch nightly.") | |||
# @unittest.skipIf(TORCH_VERSION_AT_LEAST_2_5, "int4 skipping 2.5+ for now") | |||
@skip_if_rocm("ROCm development in progress") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ROCm enablement in progress" would be a better comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROCm CI enable-ment in progress. So skipping few UTs temporary, to be debugged and fixed in further PRs.
This caused CI to fail:
I'm reverting this for now |
This reverts commit a1c67b9.
Skip the unit tests for ROCm CI deployment. refer to #999
This pull request introduces a decorator to skip tests on the ROCm platform and applies this decorator across multiple test files. The most important changes include the addition of the
skip_if_rocm
decorator and its application to various test functions to handle ROCm-specific issues.Introduction of
skip_if_rocm
decorator:test/test_utils.py
: Added theskip_if_rocm
decorator to skip tests on the ROCm platform with a custom message.Application of
skip_if_rocm
decorator:test/dtypes/test_affine_quantized.py
: Applied@skip_if_rocm
to multiple test functions and imports. [1] [2] [3] [4]test/dtypes/test_floatx.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/float8/test_base.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/hqq/test_hqq_affine.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/integration/test_integration.py
: Applied@skip_if_rocm
to multiple test functions and imports. [1] [2] [3] [4] [5] [6]test/kernel/test_galore_downproj.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/prototype/test_awq.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/prototype/test_low_bit_optim.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/prototype/test_splitk.py
: Applied@skip_if_rocm
to test functions and imports. (test/prototype/test_splitk.pyL17-R23, F6c2ed6dL19R19)test/quantization/test_galore_quant.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2]test/quantization/test_marlin_qqq.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2] [3]test/sparsity/test_marlin.py
: Applied@skip_if_rocm
to test functions and imports. [1] [2] [3]test/test_ops.py
: Added a module-level skip for ROCm.test/test_s8s4_linear_cutlass.py
: Added a module-level skip for ROCm.