-
Notifications
You must be signed in to change notification settings - Fork 273
Removes pinned version for pytest #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2158
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit e0ba155 with merge base 12467d2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seems to be OK to me, cc @msaroufim @drisspg @atalman ? |
IIRC we wanted to get rid of pytest entirely, might be time to accelerate the transition? |
@msaroufim I see, then we'll need to finish this one: #1621 |
We use pretty minimal set of the PyTest features so I think it is this is fine for now, unless the failures in this PR are in fact caused by unpinning |
CI errors might be related I think, @syed-ahmed can you confirm |
@jerryzh168 Yeah, looks like the errors are real. It's happening because pytest does have a new requirement: pytorch/pytorch#127517. Looks like we workaround it: pytorch/pytorch#136158 and that's why the CI passes for PyTorch 2.6 and 2.7. I've added a |
@metascroy @manuelcandales seems like the MPS jobs are failing consistently on this and other PRs |
Actually I messed up merging this, I didn't realize sentencepiece has some test utilities at build time |
Actually I did not mess up seems like it's a flake and occurs even if i downgrade pytest again #2166 Main is healthy |
Unless 7.4.0 is actually required, we should remove this so that pip is able to resolve dependencies in other environments: