-
Notifications
You must be signed in to change notification settings - Fork 276
Graceful handling of cpp extensions #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
ab049e7
7b81743
a38866e
20f6dc2
55c540d
f9bea04
47e572b
ac44a52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what the standard should be, but I know other tests (ex. quantization) import some boolean like "TORCH_VERSION_AFTER_2_4" and use that instead of a try except block There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the main problem is we are not sure why/when the import fails, so the boolean probably won't help here.. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On wsl2:
USE_CPP=0 pip install -e. runs into https://pastebin.com/CMhYTn20
but USE_CPP=0 python setup.py develop works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip installing wheel fixed this issue. Maybe add this to
dev-requirements.txt