Unify llama generate utils #3318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3318
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
albanD
reviewed
Nov 11, 2025
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Sounds good to me.
But I'll let an ao maintainer accept the PR
jerryzh168
approved these changes
Nov 11, 2025
jerryzh168
reviewed
Nov 11, 2025
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
looks good, as long as it works
jerryzh168
reviewed
Nov 11, 2025
torchao/_models/llama/generate.py
Outdated
| if torch.xpu.is_available() | ||
| else "cpu" | ||
| ) | ||
| default_device = acc.type if (acc := torch.accelerator.current_accelerator(True)) else "cpu" |
Contributor
There was a problem hiding this comment.
maybe spell out the arg of current_accelerator to be clearer https://docs.pytorch.org/docs/stable/generated/torch.accelerator.current_accelerator.html
guangyey
force-pushed
the
guangyey/1st
branch
from
57478ea to
09e0994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unify llama generate utils via
torch.acceleratorAPIs.cc @albanD