add support for torch.chunk to float8tensor
#3334
Open
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3334
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 027eadf with merge base b5587e4 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Nov 12, 2025
Summary: This is needed for LLaMa 4 MoE model weight loading, such as here: https://github.com/vllm-project/vllm/blob/34553b9d2702dd2a27a578fec819e88e76dcbfb4/vllm/model_executor/models/llama4.py#L455 Test Plan: ``` pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -x -k chunk ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 843a40b ghstack-comment-id: 3523627462 Pull-Request: #3334
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Nov 12, 2025
Summary: This is needed for LLaMa 4 MoE model weight loading, such as here: https://github.com/vllm-project/vllm/blob/34553b9d2702dd2a27a578fec819e88e76dcbfb4/vllm/model_executor/models/llama4.py#L455 Test Plan: ``` pytest test/quantization/quantize_/workflows/float8/test_float8_tensor.py -s -x -k chunk ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 54dd86f ghstack-comment-id: 3523627462 Pull-Request: #3334
vkuzo
added
the
topic: improvement
jcaip
approved these changes
Nov 12, 2025
| @implements(aten.split.Tensor) | ||
| def _(func, types, args, kwargs): | ||
| tensor, split_size_or_sections, dim = args | ||
| assert isinstance(split_size_or_sections, int), "unimplemented" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is needed for LLaMa 4 MoE model weight loading,
such as here:
https://github.com/vllm-project/vllm/blob/34553b9d2702dd2a27a578fec819e88e76dcbfb4/vllm/model_executor/models/llama4.py#L455
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: