-
Notifications
You must be signed in to change notification settings - Fork 390
Remove support for quant_llm_linear #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/howardzhang-cv/1/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3520
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 80d8cd1 with merge base 27c5eb9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: 69c1877 Pull-Request: #3520
|
probably have to delete this and related tests etc. as well:
you can search for |
|
First time working with the torchao repo so not really sure if this is the right way to do it: |
|
@howardzhang-cv I think it might be cleaner if you delete the |
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Removed all tests/references to floatx_tensor_core_layout and FloatXTensorCoreLayout Removed all tests/references to FPXWeightOnlyConfig Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: fe8afeb Pull-Request: #3520
|
Since they seemed pretty intertwined (since floatx seems to only use quant_llm_linear), it made a bit more sense to me to add them to this PR as well. I removed all the references/tests to floatx_tensor_core_layout and FPXWeightOnlyConfig. That included quite a bit more code changes and deletions, so please check over to make sure I didn't delete anything important. There was also the float8 layouts and cutlass_semi_sparse layouts that were in the floatx folder that I kept and did not delete. There are a couple references to |
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Removed all tests/references to floatx_tensor_core_layout and FloatXTensorCoreLayout Removed all tests/references to FPXWeightOnlyConfig Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: c124f6d Pull-Request: #3520
jerryzh168
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! we can land as long as the CI pass I think
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Removed all tests/references to floatx_tensor_core_layout and FloatXTensorCoreLayout Removed all tests/references to FPXWeightOnlyConfig Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: 750701f Pull-Request: #3520
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Removed all tests/references to floatx_tensor_core_layout and FloatXTensorCoreLayout Removed all tests/references to FPXWeightOnlyConfig Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: c4d9c5a Pull-Request: #3520
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Tasks: Related to issue [#3516](github.com//issues/3516) [ghstack-poisoned]
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls Removed all tests/references to floatx_tensor_core_layout and FloatXTensorCoreLayout Removed all tests/references to FPXWeightOnlyConfig Tasks: Related to issue [#3516](github.com//issues/3516) ghstack-source-id: 991d72b Pull-Request: #3520
|
@howardzhang-cv has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Stack from ghstack (oldest at bottom):
Summary: Deleted fp6_linear.cu and rest of fp6_llm folder
Modified ops.py (torchao/ops.py) and test_ops.py (test/test_ops.py) to remove quant_llm_linear calls
Tasks: Related to issue #3516
Differential Revision: D89908990