Skip to content

update version compatibility to allow torch 2.11.0.dev #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielvegamyhre merged 1 commit into from
Dec 31, 2025
Merged

update version compatibility to allow torch 2.11.0.dev #3545

danielvegamyhre merged 1 commit into from
Dec 31, 2025

Conversation

@danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Dec 25, 2025 •
edited
Loading

Stacked PRs:

update version compatibility to allow torch 2.11.0.dev

  • update version compatibility to allow torch 2.11.0.dev
  • Remove torch 2.9.0.dev nightlies, which are no longer active/indexed
  • Also add logic so that if one .so fails to load, we still try to load the remaining ones, rather than skipping them. I added this because I found this bug where _C_cutlass_100a.abi3.so was failing to load and preventing mxfp8 .so from being loaded:
  • Link cuda lib in mxfp8_cuda c++ extension for mxfp8 blocked layout kernel in next PR in stack

Loading /home/danvm/ao/torchao/_C_cutlass_100a.abi3.so Failed to import cpp extensions: operator torchao::_linear_8bit_act_1bit_weight does not exist

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3545

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 25, 2025
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from a1eb3e1 to 61510e2 Compare December 25, 2025 21:04
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 25, 2025
Open
@danielvegamyhre danielvegamyhre marked this pull request as draft December 26, 2025 06:16
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from 61510e2 to 3ca16f2 Compare December 26, 2025 06:16
@danielvegamyhre danielvegamyhre marked this pull request as ready for review December 26, 2025 06:16
@danielvegamyhre danielvegamyhre marked this pull request as draft December 26, 2025 21:50
@danielvegamyhre danielvegamyhre marked this pull request as ready for review December 26, 2025 21:50
@danielvegamyhre danielvegamyhre marked this pull request as draft December 26, 2025 22:02
@danielvegamyhre danielvegamyhre marked this pull request as ready for review December 26, 2025 22:03
@danielvegamyhre danielvegamyhre added topic: not user facing Use this tag if you don't want this PR to show up in release notes topic: bug fix Use this tag for PRs that fix bugs and removed topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Dec 27, 2025
danielvegamyhre
danielvegamyhre commented Dec 29, 2025
View reviewed changes
@danielvegamyhre
Copy link
Contributor Author

danielvegamyhre commented Dec 29, 2025

cc @vkuzo @andrewor14 for review

danielvegamyhre added a commit that referenced this pull request Dec 30, 2025
@danielvegamyhre
update version compatibility to allow torch 2.11.0.dev
270ebe2 
stack-info: PR: #3545, branch: danielvegamyhre/stack/91
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from 3ca16f2 to 270ebe2 Compare December 30, 2025 18:28
liangel-02
liangel-02 approved these changes Dec 30, 2025
View reviewed changes
torchao/__init__.py
(_parse_version("0.15.0"), _parse_version("2.10.0.dev")),
# Current torchao version
(_parse_version("0.16.0.dev"), _parse_version("2.9.1")),
(_parse_version("0.16.0.dev"), _parse_version("2.10.0.dev")),
Copy link
Contributor

@liangel-02 liangel-02 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this line if the torch version has been bumped?

Copy link
Contributor Author

@danielvegamyhre danielvegamyhre Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i'm not sure, there are still plenty of 2.10 nightlies active in the index people could be using: https://download.pytorch.org/whl/nightly/torch/

we also still have 2.9 nightlies listed in the compatibility table, which don't exist in the index anymore, so can probably be removed:

ao/torchao/__init__.py

Line 73 in 27c5eb9

(_parse_version("0.13.0"), _parse_version("2.9.0.dev")),

IMO we should:

  • keep 2.10 nightlies while they are still active/indexed
  • remove 2.9 nightlies which are no longer active/indexed

going to discuss in the team chat

danielvegamyhre added a commit that referenced this pull request Dec 30, 2025
@danielvegamyhre
update version compatibility to allow torch 2.11.0.dev
5d2c725 
stack-info: PR: #3545, branch: danielvegamyhre/stack/91
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from 270ebe2 to 5d2c725 Compare December 30, 2025 23:46
danielvegamyhre added a commit that referenced this pull request Dec 30, 2025
@danielvegamyhre
update version compatibility to allow torch 2.11.0.dev
a8c00b8 
stack-info: PR: #3545, branch: danielvegamyhre/stack/91
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from 5d2c725 to a8c00b8 Compare December 30, 2025 23:51
danielvegamyhre added a commit that referenced this pull request Dec 30, 2025
@danielvegamyhre
update version compatibility to allow torch 2.11.0.dev
69e3a8e 
stack-info: PR: #3545, branch: danielvegamyhre/stack/91
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from a8c00b8 to 69e3a8e Compare December 30, 2025 23:55
@danielvegamyhre
update version compatibility to allow torch 2.11.0.dev
eeb92b7 
stack-info: PR: #3545, branch: danielvegamyhre/stack/91
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/91 branch from 69e3a8e to eeb92b7 Compare December 31, 2025 01:09
@danielvegamyhre danielvegamyhre merged commit f023fab into main Dec 31, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liangel-02 liangel-02 liangel-02 approved these changes

@vkuzo vkuzo Awaiting requested review from vkuzo

@andrewor14 andrewor14 Awaiting requested review from andrewor14

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielvegamyhre @liangel-02