Skip to content

Fix failing uint4 test #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gau-nernst
Copy link
Collaborator

@gau-nernst gau-nernst commented Jul 13, 2024

torch nightly CI is failing with the following error

  test/dtypes/test_uint4.py:12: in <module>
      from torch._export import dynamic_dim
  E   ImportError: cannot import name 'dynamic_dim' from 'torch._export' (/opt/conda/envs/venv/lib/python3.9/site-packages/torch/_export/__init__.py)

Turns out dynamic_dim is not used by the test, hence can be removed. I also remove other unused imports.

New error is due to this: pytorch/pytorch#129940. _convert_weight_to_int4pack inputs should be uint8 now. @jerryzh168 do you want to handle it instead? I'm not too familiar with that part of the code, afraid to break things. Might need to update the custom unpack kernel by @jeromeku also.

Copy link

pytorch-bot bot commented Jul 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/501

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 98bcb6f with merge base 1029df3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2024
@jerryzh168
Copy link
Contributor

yeah I'll take a look at the failures

@gau-nernst
Copy link
Collaborator Author

Will be fixed by #504

@gau-nernst gau-nernst closed this Jul 16, 2024
@gau-nernst gau-nernst deleted the fix_uint4_test branch July 17, 2024 15:52
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants