[Low-bit optim] Improve compile time + Fix PyTorch 2.3 support for 4-bit optim#812
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/812
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d144f42 with merge base 599319f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
msaroufim
approved these changes
Sep 5, 2024
HDCharles
pushed a commit
that referenced
this pull request
Sep 9, 2024
…bit optim (#812) * disable recompile limit * remove _prepare_param_groups() * re-enable FSDP test. update ViT benchmarks * update * update * update readme
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
* clean up unused files * fix tests: HF TOKEN not available on-pr, add evaluation.md to tests * markup docs * fix evaluations.md * add markup to native execution md * install wget for gguf.md testing, prevent evaluation.md failures * remove secrets from yml files * update * remove copy pasta from macosand macos-mps tests * typo * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static-shape compile optim step for single parameter + disable cache size limit.
single_param_adam()is fixed -> safe to disable cache limit without the risk of always re-compiling.Benefits
Others
TODO:
benchmarks/benchmark_low_bit_adam.py)Llama2-7B benchmarks
Fine-tune Llama2-7B on Alpaca dataset. PyTorch 2.4, full BF16, 1 epoch, A100, fixed random seed. Benchmark is done with torchtune 52d1b838.
truthfulqa_mc2accNOTE: lpmm's 4-bit AdamW does not support BF16 weights.