Skip to content

Add melkwargs setting for MFCC in HuBERT pipeline #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented Nov 1, 2021

In torchaudio.compliance.kaldi.mfcc, given an 1-second torch tensor of shape (1, 16000), the shape of the MFCC feature is (98, 13).

To make torchaudio.transforms.MFCC consistent with the one above, add the melkwargs settings to match the output shape.

@nateanl nateanl changed the title Add melkwargs setting for MFCC in HuBERT setting Add melkwargs setting for MFCC in HuBERT pipeline Nov 1, 2021
@nateanl
Copy link
Member Author

nateanl commented Nov 1, 2021

Looks like the bandit failure is from ./scripts/retrieve_prs.py, could you help look into it? @carolineechen @NicolasHug Thanks!

@NicolasHug
Copy link
Member

pytorch/vision#4626 :)

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@nateanl nateanl merged commit 184466a into pytorch:main Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

Hey @nateanl!
You merged this PR, but labels were not properly added. Please add a primary and secondary label
(See https://github.com/pytorch/audio/blob/main/.github/process_commit.py)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants