PR: Build FFmpeg 4.2 #524
Merged
PR: Build FFmpeg 4.2 #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andfoy
force-pushed
the
build_ffmpeg_4.2
branch
from
f68c114 to
e18cfcb
Compare
seemethere
reviewed
Sep 21, 2020
| set -exou pipefail | ||
|
|
||
| mkdir -p "${DIR}/output/" | ||
| # This is so that circle's persist_to_workspace doesn't fail when builds don't run | ||
| touch "${DIR}/output/hello" | ||
|
|
||
| if git merge-base --is-ancestor "${FOLDER_COMMIT}" "${BASE_COMMIT}"; then | ||
| if [ $COMMIT_SAME -eq 1 ]; then |
There was a problem hiding this comment.
The previous command should just work, I don't think this change is actually necessary
There was a problem hiding this comment.
I tried to run it both locally and on the CI on the previous version, and it didn't work at all, I think it is related to the set -exou that comes after assigning the variable
There was a problem hiding this comment.
I definitely thought conditionals were exempt from the set -e erroring out, but I'm willing to just push this through since it's relatively small.
| @@ -148,17 +142,11 @@ workflows: | |||
| is-python3: true | |||
| name: ffmpeg_mac | |||
| python_version: '3.7' | |||
| - ffmpeg_win: | |||
There was a problem hiding this comment.
Should we be removing windows here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FFmpeg 4.2 builds to the PyTorch channel, it also disables packages for Windows temporarily.
See pytorch/vision#2650 and pytorch/vision#2596 (comment)
cc @seemethere @fmassa