Dependency failures when installing with cmake v4.0

[nil-is-all]

🚀 The feature, motivation and pitch

When following the docs, we end up installing the latest version of CMake (4.0). This isn't compatible with some of our deps.

Currently downgrading cmake version (e.g. to v3.28) installs the requirements, but if possible a patch to support cmake v4.0 would help. Attaching the error code while running ./install_requirements.sh -

Alternatively, we can specify in the docs that CMake 3.X is required.

CMake Deprecation Warning at /Users/nikhilviswanath/executorch/third-party/ao/build/temp.macosx-10.9-universal2-cpython-310/_deps/cpuinfo-src/CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
        Compatibility with CMake < 3.10 will be removed from a future version of
        CMake.
      
        Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
        to tell CMake that the project requires at least <min> but has been updated
        to work with policies introduced by <max> or earlier.
      
      
      -- Downloading Google Test to /Users/nikhilviswanath/executorch/third-party/ao/torchao/experimental/deps/googletest (define GOOGLETEST_SOURCE_DIR to avoid it)
      CMake Error at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
        Compatibility with CMake < 3.5 has been removed from CMake.
      
        Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
        to tell CMake that the project requires at least <min> but has been updated
        to work with policies introduced by <max> or earlier.
      
        Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
      
      
      -- Configuring incomplete, errors occurred!
      Error: could not find CMAKE_PROJECT_NAME in Cache
      -- Downloading Google Benchmark to /Users/nikhilviswanath/executorch/third-party/ao/torchao/experimental/deps/googlebenchmark (define GOOGLEBENCHMARK_SOURCE_DIR to avoid it)
      CMake Error at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
        Compatibility with CMake < 3.5 has been removed from CMake.
      
        Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
        to tell CMake that the project requires at least <min> but has been updated
        to work with policies introduced by <max> or earlier.
      
        Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
      
      
      -- Configuring incomplete, errors occurred!
      Error: could not find CMAKE_PROJECT_NAME in Cache
      CMake Deprecation Warning at deps/googlebenchmark/CMakeLists.txt:1 (cmake_minimum_required):
        Compatibility with CMake < 3.10 will be removed from a future version of
        CMake.
      
        Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
        to tell CMake that the project requires at least <min> but has been updated
        to work with policies introduced by <max> or earlier.
      
      
      -- Found Git: /usr/local/bin/git (found version "2.39.5 (Apple Git-154)")
      -- git version: v0.10.0 normalized to 0.10.0
      -- Version: 0.10.0
      -- Looking for shm_open in rt
      -- Looking for shm_open in rt - not found
      -- Performing Test HAVE_CXX_FLAG_STD_CXX11
      -- Performing Test HAVE_CXX_FLAG_STD_CXX11 - Success
      -- Performing Test HAVE_CXX_FLAG_WALL
      -- Performing Test HAVE_CXX_FLAG_WALL - Success
      -- Performing Test HAVE_CXX_FLAG_WEXTRA
      -- Performing Test HAVE_CXX_FLAG_WEXTRA - Success
      -- Performing Test HAVE_CXX_FLAG_WSHADOW
      -- Performing Test HAVE_CXX_FLAG_WSHADOW - Success
      -- Performing Test HAVE_CXX_FLAG_WERROR
      -- Performing Test HAVE_CXX_FLAG_WERROR - Success
      -- Performing Test HAVE_CXX_FLAG_WSUGGEST_OVERRIDE
      -- Performing Test HAVE_CXX_FLAG_WSUGGEST_OVERRIDE - Success
      -- Performing Test HAVE_CXX_FLAG_PEDANTIC
      -- Performing Test HAVE_CXX_FLAG_PEDANTIC - Success
      -- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS
      -- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS - Success
      -- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32
      -- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Success
      -- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING
      -- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success
      -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS
      -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS - Success
      -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED
      -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED - Success
      -- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING
      -- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success
      -- Performing Test HAVE_CXX_FLAG_WD654
      -- Performing Test HAVE_CXX_FLAG_WD654 - Failed
      -- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
      -- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Success
      -- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES
      -- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES
      -- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES -- failed to compile
      -- Performing Test HAVE_CXX_FLAG_COVERAGE
      -- Performing Test HAVE_CXX_FLAG_COVERAGE - Success
      -- Performing Test HAVE_STD_REGEX
      -- Performing Test HAVE_STD_REGEX
      -- Performing Test HAVE_STD_REGEX -- success
      -- Performing Test HAVE_GNU_POSIX_REGEX
      -- Performing Test HAVE_GNU_POSIX_REGEX
      -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
      -- Performing Test HAVE_POSIX_REGEX
      -- Performing Test HAVE_POSIX_REGEX
      -- Performing Test HAVE_POSIX_REGEX -- success
      -- Performing Test HAVE_STEADY_CLOCK
      -- Performing Test HAVE_STEADY_CLOCK
      -- Performing Test HAVE_STEADY_CLOCK -- success
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
      -- Found Threads: TRUE
      CMake Error at deps/googletest/CMakeLists.txt:4 (cmake_minimum_required):
        Compatibility with CMake < 3.5 has been removed from CMake.
      
        Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
        to tell CMake that the project requires at least <min> but has been updated
        to work with policies introduced by <max> or earlier.
      
        Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
      
      
      -- Configuring incomplete, errors occurred!
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/Users/nikhilviswanath/executorch/third-party/ao/setup.py", line 470, in <module>
          setup(
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/__init__.py", line 117, in setup
          return distutils.core.setup(**attrs)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 186, in setup
          return run_commands(dist)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 202, in run_commands
          dist.run_commands()
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 1002, in run_commands
          self.run_command(cmd)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 1104, in run_command
          super().run_command(command)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 1021, in run_command
          cmd_obj.run()
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/command/bdist_wheel.py", line 370, in run
          self.run_command("build")
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 357, in run_command
          self.distribution.run_command(command)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 1104, in run_command
          super().run_command(command)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 1021, in run_command
          cmd_obj.run()
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 135, in run
          self.run_command(cmd_name)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 357, in run_command
          self.distribution.run_command(command)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 1104, in run_command
          super().run_command(command)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 1021, in run_command
          cmd_obj.run()
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 99, in run
          _build_ext.run(self)
        File "/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 368, in run
          self.build_extensions()
        File "/Users/nikhilviswanath/executorch/third-party/ao/setup.py", line 212, in build_extensions
          self.build_cmake(ext)
        File "/Users/nikhilviswanath/executorch/third-party/ao/setup.py", line 226, in build_cmake
          subprocess.check_call(
        File "/usr/local/fbcode/platform010/Python3.10.framework/Versions/3.10/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['cmake', '/Users/nikhilviswanath/executorch/third-party/ao/torchao/experimental', '-DCMAKE_BUILD_TYPE=Release', '-DTORCHAO_BUILD_CPU_AARCH64=ON', '-DTORCHAO_BUILD_KLEIDIAI=OFF', '-DTORCHAO_BUILD_MPS_OPS=OFF', '-DTorch_DIR=/Users/nikhilviswanath/executorch/.venv/lib/python3.10/site-packages/torch/share/cmake/Torch', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/nikhilviswanath/executorch/third-party/ao/build/lib.macosx-10.9-universal2-cpython-310/torchao']' returned non-zero exit status 1.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for torchao
  Running setup.py clean for torchao
  Building wheel for pytorch_tokenizers (pyproject.toml) ... done
  Created wheel for pytorch_tokenizers: filename=pytorch_tokenizers-0.1.0-py3-none-any.whl size=10568 sha256=99e8a40dfbf8f8307919133a202735dd345a9d8e7fdb84d0aba30216ab1f9e21
  Stored in directory: /private/var/folders/r0/x7xc3kqn531_9zcrw21dsg1m0000gn/T/pip-ephem-wheel-cache-hbjgctss/wheels/d8/2b/b7/2e2bb2816b9dacb00a0bb1aed05b32656f7fb55f8b142b9203
Successfully built pytorch_tokenizers
Failed to build torchao
ERROR: Failed to build installable wheels for some pyproject.toml based projects (torchao)
Traceback (most recent call last):
  File "/Users/nikhilviswanath/executorch/./install_executorch.py", line 271, in <module>
    main(sys.argv[1:])
  File "/Users/nikhilviswanath/executorch/./install_executorch.py", line 243, in main
    install_requirements(use_pytorch_nightly)
  File "/Users/nikhilviswanath/executorch/install_requirements.py", line 127, in install_requirements
    subprocess.run(
  File "/usr/local/fbcode/platform010/Python3.10.framework/Versions/3.10/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/Users/nikhilviswanath/executorch/.venv/bin/python3', '-m', 'pip', 'install', '--no-build-isolation', 'third-party/ao', 'extension/llm/tokenizers']' returned non-zero exit status 1.

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

cc @larryliu0820 @jathu

[jathu]

@nil-is-all we've pinned CMake to <4.0 in the code already #9732

[nil-is-all]

@jathu, in the v5.0 release tutorial, the step to set up executorch stated to pip install --upgrade cmake which changes the version to cmake v4.0. We can probably close it as the v6.0 documentation does not face this issue.