Skip to content

Pin cmake version < 4.0.0 #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Pin cmake version < 4.0.0 #9732

merged 3 commits into from
Mar 28, 2025

Conversation

larryliu0820
Copy link
Contributor

Summary

So that we can still build third-party projects.

Test plan

CI

Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9732

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit ccf5362 with merge base 8b948e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 merged commit 399a255 into main Mar 28, 2025
87 checks passed
@larryliu0820 larryliu0820 deleted the larryliu0820-patch-9 branch March 28, 2025 04:59
@larryliu0820
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.6 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 28, 2025
### Summary
So that we can still build third-party projects.

### Test plan
CI

(cherry picked from commit 399a255)
@pytorchbot
Copy link
Collaborator

Cherry picking #9732

The cherry pick PR is at #9750 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary
So that we can still build third-party projects.

### Test plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants