Skip to content

A simple install command gives everything a user need #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
larryliu0820 opened this issue Dec 30, 2024 · 1 comment · Fixed by #7473
Closed

A simple install command gives everything a user need #7460

larryliu0820 opened this issue Dec 30, 2024 · 1 comment · Fixed by #7473
Assignees
@larryliu0820
Labels
module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
0.6.0

Comments

@larryliu0820
Copy link
Contributor

larryliu0820 commented Dec 30, 2024 •
edited by pytorch-bot bot
Loading

  • We should use pip install . after pulling down all code from github. (not install_requirements.sh, at least not in official releases)
    That command by default build xnnpack and pybind.
  • If a user tries to lower to other backends that are not built by default, we should give graceful error messages.

cc @mergennachin @byjlw
@larryliu0820 larryliu0820 converted this from a draft issue Dec 30, 2024
@larryliu0820 larryliu0820 changed the title A simple command gives everything a user need A simple install command gives everything a user need Dec 30, 2024
@byjlw byjlw added the module: user experience Issues related to reducing friction for users label Dec 30, 2024
mergennachin added a commit that referenced this issue Jan 2, 2025
@mergennachin
Install torchao by default
e981341 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460
This was referenced Jan 2, 2025
Merged
Merged
@mergennachin mergennachin moved this from To triage to In progress in ExecuTorch DevX Jan 2, 2025
mergennachin added a commit that referenced this issue Jan 2, 2025
@mergennachin
Install torchao by default (#7470)
a861294 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460
@github-project-automation github-project-automation bot moved this from In progress to Done in ExecuTorch DevX Jan 3, 2025
@mergennachin mergennachin moved this from Done to In progress in ExecuTorch DevX Jan 3, 2025
@mergennachin mergennachin reopened this Jan 3, 2025
@github-project-automation github-project-automation bot moved this from In progress to Backlog in ExecuTorch DevX Jan 3, 2025
@mergennachin mergennachin moved this from Backlog to In progress in ExecuTorch DevX Jan 3, 2025
@swolchok
Copy link
Contributor

swolchok commented Jan 9, 2025

not install_requirements.sh

should we remove building ExecuTorch from install_requirements.sh? Building ExecuTorch is not a requirement to build ExecuTorch. :)

pytorchbot pushed a commit that referenced this issue Jan 16, 2025
@mergennachin @pytorchbot
Install torchao by default (#7470)
7b16b35 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460

(cherry picked from commit a861294)
@pytorchbot pytorchbot mentioned this issue Jan 16, 2025
Closed
mergennachin added a commit that referenced this issue Jan 17, 2025
@mergennachin
Install torchao by default (#7470)
4750927 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460

(cherry picked from commit a861294)
mergennachin added a commit that referenced this issue Jan 17, 2025
@mergennachin @SS-JIA
Manual cherry-pick to update numpy as well as all dependencies (#7727)
5da6235 
* Install torchao by default (#7470)

Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460

(cherry picked from commit a861294)

* Upgrade numpy version requirement to 2.0 (#7599)

Upgrade numpy version requirement to

Summary:

1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0

We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip

We had to upgrade to the latest transformers as well

(cherry picked from commit a7b5297)

* Update torchtune pin (#7670)

(cherry picked from commit a18f6e8)

* [Arm] TOSA reference model update

* Install release version of torchtune

---------

Co-authored-by: Sicheng Stephen Jia <[email protected]>
@mergennachin mergennachin added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 4, 2025
@mergennachin mergennachin added this to the 0.6.0 milestone Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch Core Feb 11, 2025
@iseeyuan iseeyuan moved this from To triage to Ready in ExecuTorch Core Feb 11, 2025
@mergennachin mergennachin moved this from In progress to Done in ExecuTorch DevX Mar 27, 2025
@mergennachin mergennachin closed this as completed by moving to Done in ExecuTorch DevX Mar 27, 2025
@github-project-automation github-project-automation bot moved this from Ready to Done in ExecuTorch Core Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larryliu0820 larryliu0820

Labels
module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
ExecuTorch Core
Status: Done
ExecuTorch DevX
Status: Done
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Update install_requirements to install --pybind xnnpack by default. pytorch/executorch
4 participants
@swolchok @mergennachin @byjlw @larryliu0820