Skip to content

Optimized linear op doesn't support bias #8234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swolchok opened this issue Feb 5, 2025 · 3 comments
Open

Optimized linear op doesn't support bias #8234

swolchok opened this issue Feb 5, 2025 · 3 comments
Labels
actionable Items in the backlog waiting for an appropriate impl/fix enhancement Not as big of a feature, but technically not a bug. Should be easy to fix good first issue Good for newcomers module: kernels Issues related to kernel libraries and utilities, and code under kernels/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@swolchok
Copy link
Contributor

swolchok commented Feb 5, 2025 •
edited
Loading

🐛 Describe the bug

I left it out for implementation expediency. See

executorch/kernels/optimized/cpu/op_linear.cpp

Line 32 in 440a3ac

"bias not supported yet in linear");
.

I believe all that needs to be done is to get the bias into the C matrix passed to GEMM and then set beta to 1.0 per https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3 .

Versions

N/A

cc @larryliu0820 @manuelcandales
@swolchok swolchok added actionable Items in the backlog waiting for an appropriate impl/fix enhancement Not as big of a feature, but technically not a bug. Should be easy to fix good first issue Good for newcomers module: kernels Issues related to kernel libraries and utilities, and code under kernels/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 5, 2025
@DavitGrigoryan132
Copy link

Hi @swolchok, I would be happy to work on this issue

This was referenced Feb 11, 2025
Open
Open
This was referenced Feb 24, 2025
Open
Open
@swolchok
Copy link
Contributor Author

swolchok commented Mar 7, 2025 •
edited
Loading

Hi @swolchok, I would be happy to work on this issue

How's it going?

@DavitGrigoryan132
Copy link

DavitGrigoryan132 commented Mar 17, 2025 •
edited
Loading

Hi @swolchok the functionality is implemented and tested, will add tests and create PR soon

@DavitGrigoryan132 DavitGrigoryan132 mentioned this issue Mar 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Items in the backlog waiting for an appropriate impl/fix enhancement Not as big of a feature, but technically not a bug. Should be easy to fix good first issue Good for newcomers module: kernels Issues related to kernel libraries and utilities, and code under kernels/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
New Contributors Projects and Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swolchok @DavitGrigoryan132