-
Notifications
You must be signed in to change notification settings - Fork 537
Added support for bias in optimized linear operation #9527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added support for bias in optimized linear operation #9527
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9527
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit b637f4b with merge base 77c35f5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
9c392a9
to
b5b3702
Compare
@pytorchbot label "topic: not user facing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this! just some straightforward stuff to improve; the test is the most important of the concerns by far
b5b3702
to
14a52fc
Compare
Signed-off-by: David Grigoryan <[email protected]>
14a52fc
to
b637f4b
Compare
Hi @swolchok can you please review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Hey @swolchok thanks for reviewing the PR. Are there anything from my side that I need to do for PR to be merged? |
there are CI issues, particularly 1) lintrunner and 2) UBSAN on tests. can you please fix them? |
Summary
#8234
This PR is adding a functionality to use bias in optimized linear operation