[pytorch/executorch][diff_train] [ez][release blocker fix] Insert linalg_vector_norm into decomp table used for Edge export (#9938)
#10046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalg_vector_norm` into decomp table used for Edge export (#9938) ## Context Addresses this [release blocker](https://github.com/orgs/pytorch/projects/99/views/1?pane=issue&itemId=104088363&issue=pytorch%7Cpytorch%7C150207) issue. Some models cannot export because they use `linalg_vector_norm` which is not currently an ATen operator. I initially tried adding the op to the core decomp table, but the decomp is not passing pytorch correctness tests. Please see pytorch/pytorch#150241 for more details. ## Changes Since we currently cannot include the op in PyTorch's decomp table, instead we can insert the op into the edge decomp table directly. This PR is a simple change to add `linalg_vector_norm` directly to the edge decomp table. Internal: << DO NOT EDIT BELOW THIS LINE >> **GitHub Author**: Sicheng Stephen Jia <[email protected]> (Meta Employee) **GitHub Repo**: [pytorch/executorch](https://github.com/pytorch/executorch) **GitHub Pull Request**: [#9938](#9938) Initially generated by: https://www.internalfb.com/intern/sandcastle/job/4503601401156690/ This was imported as part of a Diff Train. Please review this as soon as possible. Since it is a direct copy of a commit on GitHub, there shouldn't be much to do. diff-train-source-id: c2e3e17 Differential Revision: [D72729066](https://our.internmc.facebook.com/intern/diff/D72729066/) [ghstack-poisoned]
kimishpatel
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10046
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 13 PendingAs of commit 2e1d282 with merge base 1facfa9 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
|
accidentally ran ghexport on top of this |
kimishpatel
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Addresses this release
blocker
issue. Some models cannot export because they use
linalg_vector_normwhich is not currently an ATen operator.
I initially tried adding the op to the core decomp table, but the decomp
is not passing pytorch correctness tests. Please see
pytorch/pytorch#150241 for more details.
Changes
Since we currently cannot include the op in PyTorch's decomp table,
instead we can insert the op into the edge decomp table directly.
This PR is a simple change to add
linalg_vector_normdirectly to theedge decomp table.
Internal:
<< DO NOT EDIT BELOW THIS LINE >>
GitHub Author: Sicheng Stephen Jia [email protected] (Meta Employee)
GitHub Repo: pytorch/executorch
GitHub Pull Request: #9938
Initially generated by: https://www.internalfb.com/intern/sandcastle/job/4503601401156690/
This was imported as part of a Diff Train.
Please review this as soon as possible. Since it is a direct copy of a commit on
GitHub, there shouldn't be much to do.
diff-train-source-id: c2e3e17
Differential Revision: D72729066