Add aten_lib to executorch_llama #10307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
JacobSzwejbka,
tarun292 and
Gasoonjia
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10307
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 79e1a8f with merge base 1afb25e ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73282334 |
tarun292
approved these changes
Apr 18, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
Summary: We now can link both ATen lib and portable lib into the same binary/.so file. This makes us easy to use aten_mode lib as well as portable lib in the same bento kernel. Differential Revision: D73282334
facebook-github-bot
force-pushed
the
export-D73282334
branch
from
1eccceb to
9b308ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73282334 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 19, 2025
Summary: We now can link both ATen lib and portable lib into the same binary/.so file. This makes us easy to use aten_mode lib as well as portable lib in the same bento kernel. Reviewed By: Gasoonjia Differential Revision: D73282334
facebook-github-bot
force-pushed
the
export-D73282334
branch
from
9b308ee to
3ea52dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73282334 |
Summary: We now can link both ATen lib and portable lib into the same binary/.so file. This makes us easy to use aten_mode lib as well as portable lib in the same bento kernel. Reviewed By: Gasoonjia Differential Revision: D73282334
facebook-github-bot
force-pushed
the
export-D73282334
branch
from
3ea52dc to
79e1a8f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73282334 |
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D73282334 Pull Request resolved: pytorch#10307
zhenyan-zhang-meta
added a commit
that referenced
this pull request
Apr 30, 2025
…-Aten Separate `extension.Module` Namespaces to be `executorch::extension::module` and `executorch::extension::module_aten`, otherwise in the future there will be issues like P1799454769. It's similar to what we already did for bundled_program in #10307 Differential Revision: [D73903870](https://our.internmc.facebook.com/intern/diff/D73903870/) [ghstack-poisoned]
zhenyan-zhang-meta
added a commit
that referenced
this pull request
Apr 30, 2025
…ten and non-Aten" Separate `extension.Module` Namespaces to be `executorch::extension::module` and `executorch::extension::module_aten`, otherwise in the future there will be issues like P1799454769. It's similar to what we already did for bundled_program in #10307 Differential Revision: [D73903870](https://our.internmc.facebook.com/intern/diff/D73903870/) [ghstack-poisoned]
zhenyan-zhang-meta
added a commit
that referenced
this pull request
Apr 30, 2025
…ten and non-Aten"
# Context
Separate `extension.Module` Namespaces to be `executorch::extension::module` and `executorch::extension::module::aten`, otherwise if a package relies on both aten and non-aten of the same implementation and the namespace is the same, there will be duplicate symbol issue like:
```
ld.lld: error: duplicate symbol: vtable for executorch::extension::Module
>>> defined at {redacted}/executorch/extension/module/__module__/__stripped__/module.cpp.pic.stripped.o:(vtable for executorch::extension::Module)
>>> defined at {redacted}/executorch/extension/module/__module_aten__/__stripped__/module.cpp.pic.stripped.o:
```
# Proposal
Doing something similar to what we already did for `bundled_program` in #10307
Since `extension.Module` is a public API, we introduce a namespace alias, so that existing use cases won't get affected. Since namespace alias doesn't create additional symbols, there won't be duplicate symbol issue.
Differential Revision: [D73903870](https://our.internmc.facebook.com/intern/diff/D73903870/)
[ghstack-poisoned]
zhenyan-zhang-meta
added a commit
that referenced
this pull request
May 5, 2025
…amespaces from Aten and non-Aten"
# Context
Separate `extension.Module` Namespaces to be `executorch::extension::module` and `executorch::extension::module::aten`, otherwise if a package relies on both aten and non-aten of the same implementation and the namespace is the same, there will be duplicate symbol issue like:
```
ld.lld: error: duplicate symbol: vtable for executorch::extension::Module
>>> defined at {redacted}/executorch/extension/module/__module__/__stripped__/module.cpp.pic.stripped.o:(vtable for executorch::extension::Module)
>>> defined at {redacted}/executorch/extension/module/__module_aten__/__stripped__/module.cpp.pic.stripped.o:
```
# Proposal
Doing something similar to what we already did for `bundled_program` in #10307
Since `extension.Module` is a public API, we introduce a namespace alias, so that existing use cases won't get affected. Since namespace alias doesn't create additional symbols, there won't be duplicate symbol issue.
Differential Revision: [D73903870](https://our.internmc.facebook.com/intern/diff/D73903870/)
[ghstack-poisoned]
zhenyan-zhang-meta
added a commit
that referenced
this pull request
May 5, 2025
…ten and non-Aten"
# Context
Separate `extension.Module` Namespaces to be `executorch::extension::module` and `executorch::extension::module::aten`, otherwise if a package relies on both aten and non-aten of the same implementation and the namespace is the same, there will be duplicate symbol issue like:
```
ld.lld: error: duplicate symbol: vtable for executorch::extension::Module
>>> defined at {redacted}/executorch/extension/module/__module__/__stripped__/module.cpp.pic.stripped.o:(vtable for executorch::extension::Module)
>>> defined at {redacted}/executorch/extension/module/__module_aten__/__stripped__/module.cpp.pic.stripped.o:
```
# Proposal
Doing something similar to what we already did for `bundled_program` in #10307
Since `extension.Module` is a public API, we introduce a namespace alias, so that existing use cases won't get affected. Since namespace alias doesn't create additional symbols, there won't be duplicate symbol issue.
Differential Revision: [D73903870](https://our.internmc.facebook.com/intern/diff/D73903870/)
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We now can link both ATen lib and portable lib into the same binary/.so file.
This makes us easy to use aten_mode lib as well as portable lib in the same bento kernel.
Reviewed By: tarun292
Differential Revision: D73282334