Skip to content

Minibench refactor #10376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

Minibench refactor #10376

merged 3 commits into from
Apr 23, 2025

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Apr 23, 2025

Allow running generic model benchmark before LLM

Now all models use the same org.pytorch.minibench.BenchmarkActivity

Allow running generic model benchmark before LLM
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10376

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 290e947 with merge base fa52f0c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kirklandsign kirklandsign marked this pull request as ready for review April 23, 2025 00:06
@kirklandsign kirklandsign requested a review from tarun292 as a code owner April 23, 2025 00:06
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 23, 2025 00:51 — with GitHub Actions Inactive
Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the linter issue to fix

@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 23, 2025 05:12 — with GitHub Actions Inactive
@kirklandsign kirklandsign temporarily deployed to upload-benchmark-results April 23, 2025 06:35 — with GitHub Actions Inactive
@kirklandsign kirklandsign merged commit ebab7bb into main Apr 23, 2025
93 checks passed
@kirklandsign kirklandsign deleted the android-llm-forward-report branch April 23, 2025 06:38
kirklandsign added a commit that referenced this pull request Apr 23, 2025
kirklandsign added a commit that referenced this pull request Apr 23, 2025
This reverts commit ebab7bb.

Broke llama benchmarking.
kirklandsign added a commit that referenced this pull request Apr 23, 2025
SS-JIA added a commit that referenced this pull request Apr 23, 2025
* main:
  [ET-VK] Enable int8 tiled compute shader to be used with buffer tensors (#10415)
  Revert "Migrate elementwise_util callers to the variants with out_dtypes in template arguments" (#10411)
  Revert "Save some size in dtype_util when dtype selective build is not in use" (#10410)
  Generalize view_copy fusion.
  Add job_arn  to benchmark result (#10372)
  Revert "Minibench refactor (#10376)" (#10405)
  Revert "Arm backend: Populate __init__.py for quantizer and Arm root" (#10395)
  Arm backend: Convert assert to throw ValueError in op_log (#10392)
  Arm backend: Add Tutorial to Example tab on the Docs page (#10386)
  Arm backend: Update node visitors to support TOSA 1.0 (#10390)
  Arm backend: Make it easier to generate non delegated/quantized PTEs (#10387)
  Arm backend: Allow --quantize in non delegated using aot_arm_compiler (#10385)
  Arm backend: Set REGIONCFG registers of the Ethos-U (#10388)
kirklandsign added a commit that referenced this pull request Apr 23, 2025
kirklandsign added a commit that referenced this pull request Apr 24, 2025
kirklandsign added a commit that referenced this pull request Apr 24, 2025
kirklandsign added a commit that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants