Skip to content

Arm backend: Update more node visitors to support TOSA 1.0 #10425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 24, 2025
Merged

Arm backend: Update more node visitors to support TOSA 1.0 #10425

merged 20 commits into from
Apr 24, 2025

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Apr 24, 2025 •
edited by pytorch-bot bot
Loading

Summary

Updates more node visitors to support TOSA 1.0 specification.

Test plan

Tested through public and internal CI.

cc @digantdesai @freddan80 @per @zingo

@oscarandersson8218
Arm backend: Support for reduce_any for TOSA 1.0
ce7b9cb 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I5f3723cbeece66420a61031a6fb2de9f852bd39c
@oscarandersson8218
Arm backend: Support for concat for TOSA 1.0
0c6892a 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I3a373871b2a6187d3b42e90ec3ca14da4034a225
@oscarandersson8218
Arm backend: Support for ERF for TOSA 1.0
57b193e 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ic028ce92c3dd20df0b8e416a7a1584ed642c5b12
@oscarandersson8218
Arm backend: Support for exp for TOSA 1.0
03b4997 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I0b25308a298545f575c80fe0fd2ddab9139d214c
@oscarandersson8218
Arm backend: Support for log for TOSA 1.0
b55ad4b 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ie589c3113a940898f773d1e2c10e161e052bf7ac
@oscarandersson8218
Arm backend: Support for permute for TOSA 1.0
273fa6a 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Icb42299c2e1d2bf0ab7581d1ce925e8ad46ecf7e
@oscarandersson8218
Arm backend: Support for pow for TOSA 1.0
a0a758d 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Iea00e770763ddc969e19e26c1c674de5fb2f36e8
@oscarandersson8218
Arm backend: Support for reciprocal for TOSA 1.0
0384ed2 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ia3235aa71652e019ed51452cd521d71c105eec70
@oscarandersson8218
Arm backend: Support for right_shift for TOSA 1.0
9256398 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ib4c3ab90ea9fe902de8d6da4109927dfe81de1f2
@oscarandersson8218
Arm backend: Support for rsqrt for TOSA 1.0
fad0e19 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I4e40d7eed3812b23d0cfba2104b62cf4e3137cb5
@oscarandersson8218
Arm backend: Support for sigmoid for TOSA 1.0
ca9f091 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I7166219c9f3dc2fd62aea649455752b130af12ce
@oscarandersson8218
Arm backend: Support for tanh for TOSA 1.0
575afda 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: If808a7b82917ac5bc8de57c67ddaec630128e07b
@oscarandersson8218
Arm backend: Support for upsample_nearest TOSA 1.0
f10eb69 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I4ad6a067d2cc0e810889d688ed4cb162ae3ff638
@oscarandersson8218
Arm backend: Support for where.self for TOSA 1.0
3358e9b 
Adds support for where.self which maps to TOSA.SELECT.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I487dfd3621b198e9b2c779dc5f7f0fabe9854506
@oscarandersson8218
Arm backend: Support for binary ops for TOSA 1.0
861b4f7 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ie7c6ac4fe2c6f78d1b529d73f5ad97fa3ef4693e
@oscarandersson8218
Arm backend: Support for unary ops for TOSA 1.0
3a54bdd 
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I1b00cac0aec8de1dff1b2a174f72446ca2410ced
@oscarandersson8218
Arm backend: Support for avg_pool2d for TOSA 1.0
804866f 
Add support for AVG_POOL2D TOSA 1.0

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ic778d4c0cb0cdafae366d36c995992d743200f9f
@oscarandersson8218
Arm backend: Support for max_pool2d for TOSA 1.0
9f3a16d 
Add support for MAX_POOL2D TOSA 1.0

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I3432622ede7b029e78ca8af5c9c71f17f551d4b3
@oscarandersson8218
Arm backend: Support for constant_pad for TOSA 1.0
0a06a5e 
Add support for PAD in TOSA 1.0. Also moves rewrites old constant_pad
tests.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I653e27b68e89e6d30a57e027aa14c1d1732ad272
@oscarandersson8218
Arm backend: Support for sin and cos for TOSA 1.0
c1633ed 
SIN and COS were introduced in TOSA 1.0. This patch adds support for
both. It also adds unittests for both ops.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ic5a71a677b06045c067c0990b2b7f04ca5e98e2b
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10425

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c1633ed with merge base d31ef13 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 24, 2025
@zingo zingo merged commit 032ba6c into pytorch:main Apr 24, 2025
252 of 256 checks passed
jackzhxng added a commit that referenced this pull request Apr 24, 2025
@jackzhxng
Revert "Arm backend: Update more node visitors to support TOSA 1.0 (#…
2266c6a 
…10425)"

This reverts commit 032ba6c.
@jackzhxng jackzhxng mentioned this pull request Apr 24, 2025
Merged
jackzhxng added a commit that referenced this pull request Apr 24, 2025
@jackzhxng
Revert "Arm backend: Update more node visitors to support TOSA 1.0" (#…
cc73c7e 
…10455)

Reverts #10425
@digantdesai
Copy link
Contributor

Yeah we don't have 1.0 internally yet, I can pull it in. I wanted to discuss with @per how this is going to evolve going forward, but we didn't sync yesterday :(

digantdesai
digantdesai reviewed Apr 24, 2025
View reviewed changes
backends/arm/operators/op_cos.py
# pyre-unsafe
from typing import List

import serializer.tosa_serializer as ts # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be inside the class and it might work

digantdesai
digantdesai reviewed Apr 25, 2025
View reviewed changes
backends/arm/operators/op_upsample_nearest2d.py
inputs: List[TosaArg],
output: TosaArg,
) -> None:
import tosa_tools.v0_80.serializer.tosa_serializer as ts # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to move
from tosa_tools.v0_80.tosa.ResizeMode import ResizeMode here as well? Also do the same for v1.0 i.e. from tosa.ResizeMode import ResizeMode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch!

@oscarandersson8218
Copy link
Collaborator Author

Yeah we don't have 1.0 internally yet, I can pull it in. I wanted to discuss with @per how this is going to evolve going forward, but we didn't sync yesterday :(

I'm struggling to see how this is any different from #10390 with regards to TOSA 1.0. Is it the sin and cos which are causing the issues?

digantdesai added a commit that referenced this pull request Apr 25, 2025
@digantdesai
[ExecuTorch] Arm backend: Update more node visitors to support TOSA 1…
fc835a9 
….0 (#10425)

Relanding

Differential Revision: [D73642292](https://our.internmc.facebook.com/intern/diff/D73642292/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2025
@digantdesai
[ExecuTorch] Arm backend: Update more node visitors to support TOSA 1…
d4c62ea 
….0 (#10425)

Differential Revision: D73642292

Pull Request resolved: #10479
kirklandsign pushed a commit that referenced this pull request Apr 26, 2025
@digantdesai @kirklandsign
[ExecuTorch] Arm backend: Update more node visitors to support TOSA 1…
fd4a533 
….0 (#10425)

Relanding

Differential Revision: [D73642292](https://our.internmc.facebook.com/intern/diff/D73642292/)

ghstack-source-id: 280313780
Pull Request resolved: #10479
kirklandsign pushed a commit that referenced this pull request Apr 26, 2025
@pytorchbot
[ExecuTorch] Arm backend: Update more node visitors to support TOSA 1…
a8422d2 
….0 (#10425) (#10504)

Relanding

Differential Revision: [D73642292](https://our.internmc.facebook.com/intern/diff/D73642292/)

ghstack-source-id: 280313780
Pull Request resolved: #10479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai left review comments

@zingo zingo zingo approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscarandersson8218 @digantdesai @zingo @facebook-github-bot