Skip to content

Pass one NDM to backend init #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/lucylq/69/base
Choose a base branch
from
Open

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 28, 2025

Stack from ghstack (oldest at bottom):

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: D73679710

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10528

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit c90d4e5 with merge base df75088 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Apr 28, 2025
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

ghstack-source-id: 280710106
Pull Request resolved: #10528
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 28, 2025
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 280808267

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants