Remove #include <span> #10535
Merged
Remove #include <span> #10535
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove span.h. Seems like it is not needed. Also part of C++20, not 17, which caused some errors when I was building et tests locally. ``` error: 10:10: fatal error: span: No such file or directory 10 | #include <span> | ^~~~~~ compilation terminated. gmake\[2\]: \*\*\* \[runtime79: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/span\_test.cpp.o\] Error 1 gmake\[1\]: \*\*\* \[CMakeFiles5899: runtime/core/test/CMakeFiles/runtime\_core\_test.dir/all\] Error 2 gmake\[1\]: \*\*\* Waiting for unfinished jobs.... ``` Differential Revision: [D73810585](https://our.internmc.facebook.com/intern/diff/D73810585/) ghstack-source-id: 280789075 Pull Request resolved: #10533
pytorchbot
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10535
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 31474bf with merge base df75088 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
lucylq
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10533 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/73/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/73/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/73/orig
@diff-train-skip-merge