[ET-VK] double, short, and uint16 dtype runtime support #11365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 13 commits into gh/ahmtox/7/base from gh/ahmtox/7/head

Jun 14, 2025

Contributor

ahmtox commented Jun 4, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: D75959063


          [ET-VK] double, short, and uint16 dtype runtime support

80ecb39

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

ahmtox requested review from manuelcandales, swolchok and SS-JIA as code owners

June 4, 2025 18:02

pytorch-bot bot commented Jun 4, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11365

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 19fd52a with merge base 8cfa858 ():

NEW FAILURES - The following jobs have failed:

Build Presets / linux (llm, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Build Presets / linux (llm, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11-aarch64) / build (gh)
docker: Error response from daemon: Get "https://registry-1.docker.io/v2/": read tcp [2600:1f18:5438:e704:c3a6:dcc4:d535:5f90]:47678->[2600:1f18:2148:bc01:f43d:e203:cafd:8307]:443: read: connection reset by peer.

CANCELLED JOB - The following job was cancelled. Please retry:

Lint / android-java-format / linux-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

This was referenced Jun 4, 2025

[ET-VK][Ops] quantize ops skeleton test framework #11366

Merged

[ET-VK][Ops] quantize_per_token.default test setup #11367

Merged

[ET-VK][Ops] quantize_per_tensor.default test setup #11368

Merged

[ET-VK][Ops] quantization op shaders and impl #11369

Open

Contributor

facebook-github-bot commented Jun 4, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063

facebook-github-bot added the fb-exported label


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

This was referenced Jun 9, 2025

[ET] enabling half dtype input for quantization #11479

Merged

[ET-VK][Ops] dequantize ops skeleton test framework #11480

Merged

[ET-VK][Ops] dequantize_per_tensor.default test setup #11481

Merged

[ET-VK][Ops] dequantize_per_token.default test setup #11482

Merged

[ET-VK][Ops] dequantization op shaders and impl #11483

Open

Contributor

facebook-github-bot commented Jun 9, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

1c7a7d0

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 9, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063

manuelcandales requested changes

View reviewed changes

Contributor

manuelcandales left a comment

fix OSS lint issues


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

d40315c

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

This was referenced Jun 11, 2025

[ET] enabling half dtype output for dequantization and making logic consistent #11552

Merged

[ET-VK][Ops] enabling double support for quantization and dequantization ops #11553

Open

[ET-VK][Ops] choose_qparams ops skeleton test framework #11554

Merged

[ET-VK][Ops] choose_qparams.tensor test setup #11555

Merged

[ET-VK][Ops] choose_qparams_per_token_asymmetric.default test setup #11556

Merged

[ET-VK][Ops] choose_qparams op shaders and impl #11557

Open

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063

SS-JIA approved these changes

View reviewed changes

Contributor

SS-JIA left a comment

LGTM, aside from lint issues. Please fix those before landing.


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

a73b6bf

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063

ahmtox added the release notes: vulkan label


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

ab14fc5

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

ahmtox mentioned this pull request

[ET-VK][Ops] common test utils for converting aten types to vulkan types #11575

Merged

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

db8f9c0

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

7a5b348

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

4121e3e

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

4d246be

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

c5bae9e

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

7f85daf

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063


          Update on "[ET-VK] double, short, and uint16 dtype runtime support"

19fd52a

Creating support for double, short, and uint16 for quantization ops. Registering the short keyword since theres already support.

Also changing the cpu implementation to support half

Differential Revision: [D75959063](https://our.internmc.facebook.com/intern/diff/D75959063/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75959063

facebook-github-bot merged commit b5eea2c into gh/ahmtox/7/base

94 of 98 checks passed

facebook-github-bot deleted the gh/ahmtox/7/head branch

June 14, 2025 03:45

facebook-github-bot temporarily deployed to cherry-pick-bot

June 14, 2025 03:45

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK] double, short, and uint16 dtype runtime support #11670

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: vulkan