fix platform inconsistencies #11547
Merged
fix platform inconsistencies #11547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11547
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 3741cb4 with merge base 045b3a5 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
added a commit
to h-friederich/executorch
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Differential Revision: D76402988
h-friederich
force-pushed
the
export-D76402988
branch
from
38fe0b4 to
4f86210
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
force-pushed
the
export-D76402988
branch
from
4f86210 to
fdc42a4
Compare
h-friederich
added a commit
to h-friederich/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Reviewed By: abennacef Differential Revision: D76402988
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
force-pushed
the
export-D76402988
branch
from
fdc42a4 to
415e9ef
Compare
h-friederich
added a commit
to h-friederich/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Reviewed By: cccclai, abennacef Differential Revision: D76402988
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
added a commit
to h-friederich/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Reviewed By: cccclai, abennacef Differential Revision: D76402988
h-friederich
force-pushed
the
export-D76402988
branch
from
415e9ef to
4735456
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
force-pushed
the
export-D76402988
branch
from
4735456 to
61ce512
Compare
h-friederich
added a commit
to h-friederich/executorch
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Reviewed By: cccclai, abennacef Differential Revision: D76402988
Summary: Pull Request resolved: pytorch#11547 When underlying dependencies have platform restrictions we need to propagate them to dependencts. release notes: none Reviewed By: cccclai, abennacef Differential Revision: D76402988
|
This pull request was exported from Phabricator. Differential Revision: D76402988 |
h-friederich
force-pushed
the
export-D76402988
branch
from
61ce512 to
3741cb4
Compare
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) ghstack-source-id: 290326556 Pull Request resolved: #11648
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
…r and Mac" ## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/) cc manuelcandales cbilgin [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 13, 2025
Pull Request resolved: #11648 ## Context #11547 was landed recently which restricted vulkan operator tests to the `ANDROID` platform. Simply update to use the utility function `get_platforms()` so that the tests can run everywhere the vulkan delegate can be built. ghstack-source-id: 290331159 @exported-using-ghexport Differential Revision: [D76620647](https://our.internmc.facebook.com/intern/diff/D76620647/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When underlying dependencies have platform restrictions we need to propagate them to dependencts.
Differential Revision: D76402988