Add cmake-format linter #12868
Open
Add cmake-format linter #12868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12868
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 04b5196 with merge base 447ac26 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
larryliu0820
approved these changes
Jul 25, 2025
|
looks like the mass lint run needs to be included in this diff to avoid red required lintrunner CI. |
[ghstack-poisoned]
swolchok
requested review from
kirklandsign,
lucylq,
digantdesai and
mcr229
as code owners
swolchok
added a commit
that referenced
this pull request
Jul 25, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: 354d2b4 ghstack-comment-id: 3120541492 Pull-Request: #12868
GregoryComer
approved these changes
Jul 25, 2025
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 26, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: f0f4b2e ghstack-comment-id: 3120541492 Pull-Request: #12868
swolchok
added a commit
that referenced
this pull request
Jul 26, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: 2a57ed5 ghstack-comment-id: 3120541492 Pull-Request: #12868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117, which was released in the newest lintrunner-adapters release.