-
Notifications
You must be signed in to change notification settings - Fork 638
Arm Backend: Add support for ELU.default operator #12996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm Backend: Add support for ELU.default operator #12996
Conversation
Signed-off-by: Agrima Khare <[email protected]> Change-Id: I032414e7454d5e2cada05b788e9eed0f7b2dc97c
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12996
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 10eac2d with merge base 275adee ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "partner: arm" |
@pytorchbot label "release notes: arm" |
@pytorchbot label "ciflow/trunk" |
To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failure for Cortex-m is unrelated to this patch. Approved
It has been set to 2 as the outputs seem to stay the same regardless of what | ||
the value of input_scale is, as long as that value is not 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of input_scale is 1.0, however using the default value resulted in a type error. When passing 1 as an int, it was overridden by the default value (since both values are 1 and therefore equivalent ). So input_scale had to be changed to an int that is not 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This will unfortunately need a rebase after the TOSA 0.80.1 removal :( |
Decomposes elu into other operators/ lookup table for MI/ BI case.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218