Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Dec 17, 2025

  • Support additional_args for while by normalizing them to carried_args in a pass.
  • Support not using all while outputs.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Signed-off-by: Erik Lundell <[email protected]>

WIP: Support additional_args in while_loop

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ic04b0e75821d7ee7a734ce4ac95f3dd13fe59f87
Do this by normalizing them to carried_args in a
pass.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I24e72574abc77953ddee70a26c147101fa00af47
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Dec 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16287

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 9479cb5 with merge base d263897 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2025
@zingo
Copy link
Collaborator

zingo commented Dec 17, 2025

Oh no :( But mean abs error: is really low so it seem like it's flakey and unrelated, could be worth to just retrigger when the other tests have runned all the way.

FAILED backends/arm/test/ops/test_sdpa.py::test_sdpa_vgf_quant - AssertionError: Output 0 does not match reference output.
Given atol: 0.006777485202997923, rtol: 0.001.
Output tensor shape: torch.Size([1, 3, 197, 64]), dtype: torch.float32
Difference: max: 0.01155497133731842, abs: 0.01155497133731842, mean abs error: 5.8043679665079164e-06.
-- Model vs. Reference --
Numel: 37824, 37824
Median: 0.0, 0.0
Mean: 0.0018774077386055387, 0.0018777132326251095
Max: 0.7048531770706177, 0.7048531770706177
Min: -0.6932982206344604, -0.6932982206344604

@Erik-Lundell
Copy link
Collaborator Author

Since this pr touches while and the failing test i spda, I would assume it's a flaky test. Let me retrigger

@zingo
Copy link
Collaborator

zingo commented Dec 17, 2025

Worked, other fails unrelated.

@zingo zingo merged commit 1245ceb into pytorch:main Dec 17, 2025
440 of 445 checks passed
xingguo01 pushed a commit to xingguo01/executorch that referenced this pull request Dec 18, 2025
- Support additional_args for while by normalizing them to carried_args
in a pass.
- Support not using all while outputs.


Signed-off-by: Erik Lundell <[email protected]>
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
- Support additional_args for while by normalizing them to carried_args
in a pass.
- Support not using all while outputs.


Signed-off-by: Erik Lundell <[email protected]>
@Erik-Lundell Erik-Lundell deleted the improve-cf branch February 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants