-
Notifications
You must be signed in to change notification settings - Fork 835
Arm backend: Improve while support #16287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Erik Lundell <[email protected]> WIP: Support additional_args in while_loop Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ic04b0e75821d7ee7a734ce4ac95f3dd13fe59f87
Do this by normalizing them to carried_args in a pass. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I24e72574abc77953ddee70a26c147101fa00af47
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16287
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 9479cb5 with merge base d263897 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Oh no :( But mean abs error: is really low so it seem like it's flakey and unrelated, could be worth to just retrigger when the other tests have runned all the way. FAILED backends/arm/test/ops/test_sdpa.py::test_sdpa_vgf_quant - AssertionError: Output 0 does not match reference output. |
|
Since this pr touches while and the failing test i spda, I would assume it's a flaky test. Let me retrigger |
|
Worked, other fails unrelated. |
- Support additional_args for while by normalizing them to carried_args in a pass. - Support not using all while outputs. Signed-off-by: Erik Lundell <[email protected]>
- Support additional_args for while by normalizing them to carried_args in a pass. - Support not using all while outputs. Signed-off-by: Erik Lundell <[email protected]>
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai