Implement scheme for custom arm_pass_manager insertions (#16396)

[3l1]

Summary:

Implement scheme for custom arm_pass_manager + ...

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, Ninja91

Differential Revision: D87120925

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16396

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2e23d86 with merge base d0820e1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87120925.

[digantdesai]

Review automatically exported from Phabricator review in Meta.

[3l1]

@pytorchbot label "release notes: none"

[3l1]

NOTE: I have pending changes before merging !!

[zingo]

Hi I see you linkrunner error is

291  295 |     def _configure_pass_insertions(self, exported_program: ExportedProgram) -> None:
291      |-        """Hook for subclasses to configure pass insertions.
292      |-Called at the STARTof pipeline construction, before any passes are added.
     296 |+        """Hook for subclasses to configure pass insertions.Called at the START
     297 |+of pipeline construction, before any passes are added.
294  298 | 

I think this was fixed recently You probably need to rebase it. Ill try to rebase rebasing it here to check but you might get meta internal mismatch, let see if so you need to do it on oyr side or re-sync internal version.

[robell]

hi @3l1 - I'm hoping to use this feature for some changes I'm making - are you aiming to get it in soon? Thanks.

[zingo]

@SS-JIA / @digantdesai this has a conflicting internal Meta version stopping merge, would it be OK to re-import, thanks for the help :)

[digantdesai]

This is not available in the shims. For other uses, I guess they are in the .bzl file which is lazily loaded and never loaded in OSS? How about doing something like this,

diff --git a/backends/arm/_passes/TARGETS b/backends/arm/_passes/TARGETS
index e782018f6c..5473ffdec4 100644
--- a/backends/arm/_passes/TARGETS
+++ b/backends/arm/_passes/TARGETS
@@ -1,4 +1,3 @@
-load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

 runtime.python_library(
@@ -35,7 +34,7 @@ runtime.python_library(
     srcs = [],
     deps = [
         ":arm_pass_manager_base",
-        "//executorch/backends/arm/_passes/fb:fb",
+        # @oss-disable: "//executorch/backends/arm/_passes/fb:fb",
     ],
 )

@@ -48,7 +47,7 @@ runtime.python_library(
     ]),
     deps = [
         ":core",
-        ":arm_pass_manager_fb" if is_fbcode else ":arm_pass_manager_base",
+        ":arm_pass_manager_base" if runtime.is_oss else ":arm_pass_manager_fb",
         "//executorch/backends/arm/tosa:utils",
         "//executorch/backends/arm/tosa/dialect:lib",
         "//executorch/backends/transforms:fuse_view_copy",
diff --git a/backends/arm/test/targets.bzl b/backends/arm/test/targets.bzl
index bc7cf84808..c81413ce0f 100644
--- a/backends/arm/test/targets.bzl
+++ b/backends/arm/test/targets.bzl
@@ -1,5 +1,5 @@
 # load("//caffe2/test/fb:defs.bzl", "define_tests")
-load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
+load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
 load("@fbcode_macros//build_defs:python_pytest.bzl", "python_pytest")
 load("@bazel_skylib//lib:paths.bzl", "paths")

@@ -67,7 +67,7 @@ def define_arm_tests():
                 "//executorch/kernels/quantized:custom_ops_generated_lib",
             ],
             deps = [
-                "//executorch/backends/arm/test/tester/fb:arm_tester_fb" if is_fbcode else "//executorch/backends/arm/test:arm_tester",
+                "//executorch/backends/arm/test:arm_tester" if runtime.is_oss else "//executorch/backends/arm/test/tester/fb:arm_tester_fb",
                 "//executorch/backends/arm/test:conftest",
                 "//executorch/backends/arm/test/misc:dw_convs_shared_weights_module",
                 "//executorch/backends/arm:ethosu",