Skip to content

Implement a portable adaptive_avgpool2d kernel#18067

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
GregoryComer:portable-adaptive-avg-pool-2d
Mar 12, 2026
Merged

Implement a portable adaptive_avgpool2d kernel#18067
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
GregoryComer:portable-adaptive-avg-pool-2d

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Mar 10, 2026

Summary

Add a basic _adaptive_avgpool2d kernel to portable. It shows up in some CV models.

cc @larryliu0820 @manuelcandales

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18067

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending, 4 Unrelated Failures

As of commit 2576b9b with merge base be0cdee (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2026
@GregoryComer GregoryComer added module: kernels Issues related to kernel libraries and utilities, and code under kernels/ release notes: ops & kernels Changes to the opset and any new / changed kernel implementations labels Mar 10, 2026
@GregoryComer GregoryComer force-pushed the portable-adaptive-avg-pool-2d branch 2 times, most recently from e2b42a9 to bb23c30 Compare March 10, 2026 19:50
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 10, 2026

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D95997748.

@GregoryComer GregoryComer force-pushed the portable-adaptive-avg-pool-2d branch from bb23c30 to 9fdda5d Compare March 11, 2026 22:24
@GregoryComer GregoryComer marked this pull request as ready for review March 11, 2026 22:26
# See the README.md file in this directory for a description of the syntax used
# by this file.

- op: _adaptive_avg_pool2d.out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a underscore at the front? is this kernel internal only and won;t expose to user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. This is actually the ATen op name, so this is referencing the official schema here: https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/native_functions.yaml#L12443. I'm not sure why the ATen op itself starts with an underscore.

@GregoryComer GregoryComer force-pushed the portable-adaptive-avg-pool-2d branch from 9fdda5d to 2576b9b Compare March 12, 2026 16:41
@meta-codesync meta-codesync bot merged commit 090af6c into pytorch:main Mar 12, 2026
153 of 159 checks passed
jpiat pushed a commit to jpiat/executorch that referenced this pull request Mar 17, 2026
Differential Revision: D95997748

Pull Request resolved: pytorch#18067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: kernels Issues related to kernel libraries and utilities, and code under kernels/ release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants