Add NHWC version of max_pool2d (#18239)

[mcremon-meta]

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18239

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending, 12 Unrelated Failures

As of commit 908826d with merge base e4eeb98 ():

NEW FAILURE - The following job has failed:

• Test CUDA Builds / test-model-cuda-e2e (openai, whisper-large-v3-turbo, quantized-int4-weight-only) / linux-job (gh)
  RuntimeError: Command docker exec -t 9591de5c998d2e17534fcff649fef582577ed384509c464be84f44d4c832a8b9 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• pull / test-sqnr-static-llm-qnn-linux (smollm2_135m) / linux-job (gh) (similar failure)

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / windows / windows-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• pull / unittest-editable / windows / windows-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• Test Metal Backend / test-model-metal-e2e (mistralai, Voxtral-Mini-3B-2507, non-quantized) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (mistralai, Voxtral-Mini-3B-2507, quantized-int4-metal) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (mistralai, Voxtral-Mini-4B-Realtime-2602, quantized-int4-metal) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (nvidia, parakeet-tdt, non-quantized) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (nvidia, parakeet-tdt, quantized-int4-metal) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (openai, whisper-large-v3-turbo, non-quantized) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (openai, whisper-large-v3-turbo, quantized-int4-metal) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (openai, whisper-small, non-quantized) / macos-job (gh) (trunk failure)
• Test Metal Backend / test-model-metal-e2e (openai, whisper-small, quantized-int4-metal) / macos-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96869747.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.