Skip to content

Conv1d channel last bug fix#18258

Closed
rezaasjd wants to merge 3 commits intopytorch:mainfrom
rezaasjd:export-D97009237
Closed

Conv1d channel last bug fix#18258
rezaasjd wants to merge 3 commits intopytorch:mainfrom
rezaasjd:export-D97009237

Conversation

@rezaasjd
Copy link

Summary: Fixes Conv1d channel las indexing issue.

Differential Revision: D97009237

mcremon-meta and others added 3 commits March 9, 2026 16:01
Summary:
Update quantizer patterns to route conv1d operations to quantized_conv1d_ncl instead of quantized_conv2d_nchw:
- Conv1dPattern.replacement_op() now returns quantized_conv1d_ncl
- Conv1dReluPattern0 and Conv1dReluPattern1 now return quantized_conv1d_ncl
- Added fused_conv1d_relu test and _build_conv1d_relu_graph helper

Differential Revision: D95279330
Summary: Fixes Conv1d channel las indexing issue.

Differential Revision: D97009237
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18258

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 18, 2026

@rezaasjd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97009237.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rezaasjd rezaasjd closed this Mar 18, 2026
rezaasjd pushed a commit to rezaasjd/executorch that referenced this pull request Mar 18, 2026
Summary:

Fixes Conv1d channel las indexing issue.

Differential Revision: D97009237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants