[ET-VK] Serialize all scalar types #2414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D54873255](https://our.internmc.facebook.com/intern/diff/D54873255/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2414
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 444352b with merge base 9ff2c0e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54873255 |
jorgep31415
added a commit
that referenced
this pull request
Mar 13, 2024
Differential Revision: [D54873255](https://our.internmc.facebook.com/intern/diff/D54873255/) ghstack-source-id: 218568548 Pull Request resolved: #2414
Differential Revision: [D54873255](https://our.internmc.facebook.com/intern/diff/D54873255/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D54873255 |
jorgep31415
added a commit
that referenced
this pull request
Mar 13, 2024
Pull Request resolved: #2414 Adds all the [non-quantized scalar types from ATen Vulkan](https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/vulkan/api/Types.h#L21-L26). ``` _(uint8_t, VK_FORMAT_R8G8B8A8_UINT, Byte) \ _(int8_t, VK_FORMAT_R8G8B8A8_SINT, Char) \ _(int32_t, VK_FORMAT_R32G32B32A32_SINT, Int) \ _(bool, VK_FORMAT_R8G8B8A8_SINT, Bool) \ _(unsigned short, VK_FORMAT_R16G16B16A16_SFLOAT, Half) \ _(float, VK_FORMAT_FLOAT4, Float) \ ``` Tensor images and buffers will now be created according to this `dtype`. It's up to contributors to associate their shader to one of these dtypes, e.g., in [`all_shaders.yaml`](https://github.com/pytorch/executorch/blob/main/backends/vulkan/runtime/graph/ops/glsl/all_shaders.yaml#L32-L46). ``` image_to_nchw: ... generate_variant_forall: DTYPE: - VALUE: "half" SUFFIX: "half" - VALUE: "float" SUFFIX: "float" ... ``` Differential Revision: [D54873255](https://our.internmc.facebook.com/intern/diff/D54873255/) ghstack-source-id: 218582139
SS-JIA
approved these changes
Mar 13, 2024
|
This pull request has been merged in 1eb9a15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D54873255