Skip to content

exclude mutated buffer #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

exclude mutated buffer #2946

merged 1 commit into from
Apr 9, 2024

Conversation

pytorchbot
Copy link
Collaborator

Differential Revision: D55812844

@cccclai @pytorchbot
exclude mutated buffer (#2876)
00db807 
Summary:
Pull Request resolved: #2876

Fixing the tag constant for mutable buffer. The buffer shouldn't be tagged if it's going to be mutated by the delegated. It's more common in hardware backends

Will follow up and test having delegate consume mutation

Reviewed By: mcr229, angelayi

Differential Revision: D55812844

fbshipit-source-id: e0be4c2dc295141d673cccb1aeecee45894b1e70
(cherry picked from commit 599cfde)
@pytorchbot pytorchbot mentioned this pull request Apr 9, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2946

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 00db807 with merge base d3326a2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
@cccclai cccclai mentioned this pull request Apr 9, 2024
Closed
@mergennachin mergennachin self-requested a review April 9, 2024 20:44
@mergennachin mergennachin merged commit 2fe7543 into release/0.2 Apr 9, 2024
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pytorchbot @mergennachin @facebook-github-bot @cccclai