Fix quantized embedding export logic #3095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3095
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a28e73b with merge base 06beace ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
force-pushed
the
larryliu0820-patch
branch
2 times, most recently
from
7977cc2 to
1dc7a5c
Compare
Summary: This diff adds support for multi query attention for sdpa with kv cache Reviewed By: iseeyuan Differential Revision: D56212419
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
larryliu0820
force-pushed
the
larryliu0820-patch
branch
2 times, most recently
from
d504a61 to
4b7050d
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
larryliu0820
force-pushed
the
larryliu0820-patch
branch
from
4b7050d to
a28e73b
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@larryliu0820 merged this pull request in 2c467dd. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Summary: In #3095 there's an issue with the embedding_4bit schema which causes mismatch between functional and out variant. P1217884556 Differential Revision: D56357762
larryliu0820
added a commit
that referenced
this pull request
Apr 19, 2024
Summary: In #3095 there's an issue with the embedding_4bit schema which causes mismatch between functional and out variant. P1217884556 Differential Revision: D56357762
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patches to make 4bit quantized embedding work for export. Fixed:
packed=Truefor 4bit quantization