-
Notifications
You must be signed in to change notification settings - Fork 537
[ET-VK] Documentation for Vulkan Delegate #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3113
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67e6c48 with merge base 20bf0db ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The Vulkan Delegate libraries can be built by setting `-DEXECUTORCH_BUILD_VULKAN=ON` | ||
when building with CMake. | ||
|
||
First, make sure that you have the Android NDK installed - Android NDK r25c is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is `r25c1 required or the one tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just recommended. I mention it to be consistent with Hansong's Android app demo.
I don't think there is a hard NDK requirement except for being after when Vulkan was added (I think r17). I tested with r19 and it was able to build too.
@@ -0,0 +1,192 @@ | |||
# ExecuTorch Vulkan Delegate | |||
|
|||
The ExecuTorch Vulkan delegate is a native GPU delegate for ExecuTorch that is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a session to describe the supported platform for both AOT and runtime?
@pytorchbot cherry-pick --onto release/0.2 -c docs |
Cherry picking #3113The cherry pick PR is at #3124 Details for Dev Infra teamRaised by workflow job |
Summary: Pull Request resolved: #3113 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: cccclai Differential Revision: D56279743 Pulled By: SS-JIA fbshipit-source-id: af55cdf2d8518c582b7d8deccb731c6bc442a1c9 (cherry picked from commit 414cd05) Co-authored-by: Sicheng Jia <[email protected]>
Stack from ghstack (oldest at bottom):
Differential Revision: D56279743