Skip to content

Update Core ML Backend Doc #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

YifanShenSZ
Copy link
Collaborator

@YifanShenSZ YifanShenSZ commented Apr 20, 2024

Update Core ML backend doc on:

  1. Partitioner
  2. Quantizer

Copy link

pytorch-bot bot commented Apr 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3188

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 430f12b with merge base ee8c3a6 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2024
@YifanShenSZ YifanShenSZ marked this pull request as ready for review April 22, 2024 21:09
@YifanShenSZ
Copy link
Collaborator Author

YifanShenSZ commented Apr 22, 2024

@cymbalrush feel free to push more commits on runtime doc 🙏

@pulkital feel free to push more commits to polish quantizer doc 🙏

@cymbalrush
Copy link
Contributor

Updated tutorial.

@cymbalrush
Copy link
Contributor

Rebased on main.

ic4
linear
llama2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried llama3? If llama2 works, llama3 should be just out of box.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, going to try today.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in c004efe.

@cymbalrush
Copy link
Contributor

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 23, 2024
Summary:
Update Core ML backend doc on:
1. Partitioner
2. Quantizer

Pull Request resolved: #3188

Reviewed By: shoumikhin

Differential Revision: D56481126

Pulled By: cccclai

fbshipit-source-id: 925a107a210094e035a816a15c70d9aedd5bd369
(cherry picked from commit c004efe)
@pytorchbot
Copy link
Collaborator

Cherry picking #3188

The cherry pick PR is at #3249

Details for Dev Infra team Raised by workflow job

guangy10 pushed a commit that referenced this pull request Apr 23, 2024
Summary:
Update Core ML backend doc on:
1. Partitioner
2. Quantizer

Pull Request resolved: #3188

Reviewed By: shoumikhin

Differential Revision: D56481126

Pulled By: cccclai

fbshipit-source-id: 925a107a210094e035a816a15c70d9aedd5bd369
(cherry picked from commit c004efe)

Co-authored-by: yifan_shen3 <[email protected]>
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants