Skip to content

Add memory and vector include in managed_tensor.h #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

larryliu0820
Copy link
Contributor

Summary:
In order to get rid of this patch https://github.com/pytorch/torchchat/blob/main/scripts/install_et.sh#L35-L36

We upstream the changes into ExecuTorch.

Differential Revision: D56424633

Copy link

pytorch-bot bot commented Apr 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3201

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7cb566e with merge base 8dc54d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56424633

facebook-github-bot pushed a commit that referenced this pull request Apr 22, 2024
Summary:

In order to get rid of this patch https://github.com/pytorch/torchchat/blob/main/scripts/install_et.sh#L35-L36

We upstream the changes into ExecuTorch.

Reviewed By: lucylq

Differential Revision: D56424633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56424633

larryliu0820 added a commit that referenced this pull request Apr 22, 2024
Summary:

In order to get rid of this patch https://github.com/pytorch/torchchat/blob/main/scripts/install_et.sh#L35-L36

We upstream the changes into ExecuTorch.

Reviewed By: lucylq

Differential Revision: D56424633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56424633

Summary:

In order to get rid of this patch https://github.com/pytorch/torchchat/blob/main/scripts/install_et.sh#L35-L36

We upstream the changes into ExecuTorch.

Reviewed By: lucylq

Differential Revision: D56424633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56424633

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 90d0c1a.

larryliu0820 added a commit to pytorch/torchchat that referenced this pull request Apr 22, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
larryliu0820 added a commit to pytorch/torchchat that referenced this pull request Apr 22, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
@mergennachin mergennachin mentioned this pull request Apr 26, 2024
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit to pytorch/torchchat that referenced this pull request Jul 17, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in pytorch/executorch#3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants