Fix LLAMA app #3228
Closed
Fix LLAMA app #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix a UI thread issue causing crash. Differential Revision: D56447006
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3228
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit a402253 with merge base 9d2af4c ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56447006 |
cccclai
approved these changes
Apr 23, 2024
|
This pull request has been merged in 4389442. |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 24, 2024
Summary: Pull Request resolved: pytorch#3228 Fix a UI thread issue causing crash. Reviewed By: cccclai Differential Revision: D56447006 fbshipit-source-id: 02eff27d4b4cd108c95b664d04679d4f92aaf5db (cherry picked from commit 4389442)
This was referenced Apr 24, 2024
Merged
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 24, 2024
Summary: Pull Request resolved: pytorch#3228 Fix a UI thread issue causing crash. Reviewed By: cccclai Differential Revision: D56447006 fbshipit-source-id: 02eff27d4b4cd108c95b664d04679d4f92aaf5db (cherry picked from commit 4389442)
guangy10
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix a UI thread issue causing crash.
Differential Revision: D56447006