Add delegate time scale converter to Inspector #3240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3240
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit beba1d4 with merge base 1eaed2b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
tarun292
added a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Differential Revision: D55298701
tarun292
force-pushed
the
export-D55298701
branch
from
a10482d to
6f38f92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
Jack-Khuu
approved these changes
Apr 23, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
facebook-github-bot
force-pushed
the
export-D55298701
branch
from
6f38f92 to
05893ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
facebook-github-bot
force-pushed
the
export-D55298701
branch
from
05893ea to
646beeb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
tarun292
added a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
tarun292
force-pushed
the
export-D55298701
branch
from
646beeb to
5fa1ca3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
facebook-github-bot
force-pushed
the
export-D55298701
branch
from
5fa1ca3 to
aff8e18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
tarun292
added a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
tarun292
force-pushed
the
export-D55298701
branch
from
aff8e18 to
fa64954
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
facebook-github-bot
force-pushed
the
export-D55298701
branch
from
fa64954 to
ab62196
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
facebook-github-bot
force-pushed
the
export-D55298701
branch
from
ab62196 to
9e41de3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
tarun292
force-pushed
the
export-D55298701
branch
from
9e41de3 to
beba1d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55298701 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
tarun292
added a commit
that referenced
this pull request
Apr 24, 2024
Summary: The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701
|
This pull request has been merged in b7b40ac. |
|
@pytorchbot cherry-pick |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/0.2 |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/0.2 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 24, 2024
Summary: Pull Request resolved: #3240 The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701 fbshipit-source-id: e888e51b602c7e1ec8cb9e05ac052280daa12823 (cherry picked from commit b7b40ac)
Cherry picking #3240The cherry pick PR is at #3297 and it is recommended to link a fixnewfeature cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
guangy10
pushed a commit
that referenced
this pull request
Apr 24, 2024
Summary: Pull Request resolved: #3240 The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events. Reviewed By: Jack-Khuu Differential Revision: D55298701 fbshipit-source-id: e888e51b602c7e1ec8cb9e05ac052280daa12823 (cherry picked from commit b7b40ac) Co-authored-by: Tarun Karuturi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D55298701