Skip to content

Enable doc upload for tags, disable for release branches #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

pytorchbot
Copy link
Collaborator

  • Disabled doc upload for branches like release/x.x
  • Enabled publishing for tags.

Tested locally:

export GITHUB_REF=refs/tags/v3.1.4-rc5
bash test-version.py
# test-version.py
if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
  TARGET_FOLDER="${BASH_REMATCH[1]}"
else
  TARGET_FOLDER="main"
fi
echo "Target folder: ${TARGET_FOLDER}"

Output:

Target folder: 3.1

One more:

export GITHUB_REF=refs/tags/v1.15.4
bash test-version.sh

Output:

Target folder: 1.15

Summary:
- Disabled doc upload for branches like release/x.x
- Enabled publishing for tags.

Tested locally:
```
export GITHUB_REF=refs/tags/v3.1.4-rc5
bash test-version.py
```
```
# test-version.py
if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
  TARGET_FOLDER="${BASH_REMATCH[1]}"
else
  TARGET_FOLDER="main"
fi
echo "Target folder: ${TARGET_FOLDER}"
```
Output:
```
Target folder: 3.1
```
One more:
```
export GITHUB_REF=refs/tags/v1.15.4
bash test-version.sh
```
Output:
```
Target folder: 1.15
```

Pull Request resolved: #3153

Reviewed By: dbort

Differential Revision: D56445037

Pulled By: svekars

fbshipit-source-id: e7328523dfe308e8921c1e4f365d9a757d053191
(cherry picked from commit ee8c3a6)
Copy link

pytorch-bot bot commented Apr 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3243

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e37f0fd with merge base d3326a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@guangy10 guangy10 merged commit 1ba292a into release/0.2 Apr 23, 2024
35 checks passed
@mergennachin mergennachin mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants