Skip to content

Use relative links in llm/getting-started.md #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Apr 23, 2024

Use relative markdown links instead of full URLs. This way, the docs will always point to a consistent branch.

Test Plan:
Clicked on all modified links in the rendered docs preview: https://docs-preview.pytorch.org/pytorch/executorch/3244/llm/getting-started.html

Copy link

pytorch-bot bot commented Apr 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3244

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d75e27 with merge base e25e5d2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update!

@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Use relative markdown links instead of full URLs. This way, the docs
will always point to a consistent branch.
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dbort merged this pull request in b560864.

@dbort
Copy link
Contributor Author

dbort commented Apr 24, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 24, 2024
Summary:
Use relative markdown links instead of full URLs. This way, the docs will always point to a consistent branch.

Pull Request resolved: #3244

Test Plan: Clicked on all modified links in the rendered docs preview: https://docs-preview.pytorch.org/pytorch/executorch/3244/llm/getting-started.html

Reviewed By: Gasoonjia

Differential Revision: D56479234

Pulled By: dbort

fbshipit-source-id: 45fb25f017c73df8606c3fb861acafbdd82fec8c
(cherry picked from commit b560864)
@pytorchbot
Copy link
Collaborator

Cherry picking #3244

The cherry pick PR is at #3310

Details for Dev Infra team Raised by workflow job

@dbort dbort mentioned this pull request Apr 24, 2024
guangy10 pushed a commit that referenced this pull request Apr 24, 2024
Summary:
Use relative markdown links instead of full URLs. This way, the docs will always point to a consistent branch.

Pull Request resolved: #3244

Test Plan: Clicked on all modified links in the rendered docs preview: https://docs-preview.pytorch.org/pytorch/executorch/3244/llm/getting-started.html

Reviewed By: Gasoonjia

Differential Revision: D56479234

Pulled By: dbort

fbshipit-source-id: 45fb25f017c73df8606c3fb861acafbdd82fec8c
(cherry picked from commit b560864)

Co-authored-by: Dave Bort <[email protected]>
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants